Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Body is not updated when bodyOutputType is TrustedHtml #185

Closed
wants to merge 1 commit into from

Conversation

rmeshksar
Copy link

When the toast object is created, updating the title and body values of the object should update the toast component.
It works well in default mode and title is working in all cases.
However, when the bodyOutType is TrustedHtml, the body in the component is not getting updated.
It is due to the fact that the trusted html for the body is only calculated in the component initialization phase and not reacting to the changes.
The solution to this is to use sanitizeHtml pipe and apply it to the toast.body in the component template.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 42c0b34 on rmeshksar:master into 7980e1e on Stabzs:master.

@Stabzs
Copy link
Owner

Stabzs commented Nov 10, 2020

The library has been updated to version 10.0.0 and source has changed location. If this is still an issue, would you be willing to update the PR? Thanks!

@Stabzs
Copy link
Owner

Stabzs commented Dec 1, 2020

This has been implemented into the 11.0.0 release branch. Closing. Thank you for the contribution!

@Stabzs Stabzs closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants