Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removedToast observable #42

Closed
CaselIT opened this issue Jul 22, 2016 · 6 comments
Closed

Add removedToast observable #42

CaselIT opened this issue Jul 22, 2016 · 6 comments

Comments

@CaselIT
Copy link
Contributor

CaselIT commented Jul 22, 2016

First of all thanks for this useful library!

It would be nice to have an observable in the ToasterService which notifies when a toast has been removed, regardless of the reason. It would the opposite of the addToast observable

I you like I could make a pr with this feature.

@CaselIT
Copy link
Contributor Author

CaselIT commented Jul 28, 2016

Any update @Stabzs ?

@Stabzs
Copy link
Owner

Stabzs commented Jul 28, 2016

Thanks for the feedback and the request!

Absolutely, I can see the value in this. What would be broadcasted would be the toastId and the containerId. There is obviously a case where multiple events would be broadcasted for a toast that exists in multiple containers. I can look at adding this soon.

@CaselIT
Copy link
Contributor Author

CaselIT commented Jul 29, 2016

Great, Thanks.

@Stabzs
Copy link
Owner

Stabzs commented Aug 2, 2016

@CaselIT I haven't had time to get to this yet. If you are interested in creating a PR with tests, it would definitely help get this completed sooner :). Else I'll get to it when I can.

@CaselIT
Copy link
Contributor Author

CaselIT commented Aug 2, 2016

I'll look into it.
Thanks

@Stabzs
Copy link
Owner

Stabzs commented Sep 11, 2016

Since there hasn't been a lot of traction on this particular request, it doesn't seem to be that large of a demand. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants