Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added removeToast observable. #58

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Added removeToast observable. #58

merged 1 commit into from
Sep 12, 2016

Conversation

CaselIT
Copy link
Contributor

@CaselIT CaselIT commented Sep 11, 2016

At last I've found some time to implement this feature.
This implements #42

To avoid exposing the public _removeToastSubject in the ToasterService I've added the flag stripInternal in the tsconfig. If you prefer another solution let me know and I'll change the commit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 098dbb6876ff791be0bea13dc0631ad8deba0f8d on CaselIT:removeToast into d9bcafa on Stabzs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d148f5 on CaselIT:removeToast into d9bcafa on Stabzs:master.

@CaselIT
Copy link
Contributor Author

CaselIT commented Sep 11, 2016

I replaced the previous commit since I had inadvertently formatted the whole ToastService file, adding unnecessary formatting changes.

@Stabzs
Copy link
Owner

Stabzs commented Sep 12, 2016

Thanks for getting to this!

I think that the stripInternal flag is probably a pretty appropriate solution for this particular use case and while this is the only place it would currently be used, it seems worthwhile to use it.

@Stabzs Stabzs merged commit 157ba3a into Stabzs:master Sep 12, 2016
@CaselIT
Copy link
Contributor Author

CaselIT commented Sep 12, 2016

Thanks for merging.
👍

@Stabzs
Copy link
Owner

Stabzs commented Sep 12, 2016

You're welcome! This will go in the next feature build.

@Stabzs
Copy link
Owner

Stabzs commented Sep 14, 2016

@CaselIT this is now published as 0.5.2-rc.7.

@CaselIT
Copy link
Contributor Author

CaselIT commented Sep 14, 2016

Great, thanks @Stabzs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants