Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular2-Toaster installs own version of Angular 2 #50

Closed
bobrosoft opened this issue Aug 25, 2016 · 1 comment
Closed

Angular2-Toaster installs own version of Angular 2 #50

bobrosoft opened this issue Aug 25, 2016 · 1 comment

Comments

@bobrosoft
Copy link

Hi there!
Can you tell me why Angular 2 and RxJS is in "dependencies" instead of "peerDependencies" as it should be? Angular2-Toaster goes as a "plugin", not standalone service, right? Check https://github.com/valor-software/ng2-bootstrap/blob/development/package.json for example.

@Stabzs
Copy link
Owner

Stabzs commented Aug 25, 2016

There are plans to move these dependencies to peerDependencies per the conversation in #48. However, currently peerDependencies breaks the Karma test shim configuration. Once that is patched, the dependencies will be updated to peerDependencies.

Thanks for raising this issue. This is an important priority and something that needs to change in the very near future.

@Stabzs Stabzs closed this as completed in eebbd01 Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants