-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Angular 2.0.0 RC5 + encapsulte into NgModule #48
Conversation
The library has been updated to Angular 2.0.0-rc5 Toaster has been encapsulated in an ngModule Declarations that became obsolete have been removed Test setup has been adapted according to Angular 2.0.0-rc5 Remove unused variables Closes Stabzs#47
please move |
@bernhard-niedermayer Thank you so much for all of your hard work on this! It was a ton of cleanup in the demo projects and much-needed optimizations and it is greatly appreciated! A few fixes please, before this can be merged.
The test coverage dropped because you modified the callback on line 712. This incorrectly causes that path to no longer get tested. Please adjust test to return coverage back to 100%. Once these two modifications are made, I'll be more than happy to merge this in. |
@laco0416 I'm having difficulty justifying moving the angular2 dependencies to peerDependencies just to support nightly builds. This will certainly cause a lot of confusion for a number of users when their installs proceed with just a warning but the version isn't present for a build. Moving it to devDependency is flat out incorrect and a poor representation of the dependencies for the library. |
@Stabzs does "users" mean contributors? almost users install explicitly angular2 and then install plugins. usually, if some users (including me) want to use nightly-builds, some warning messages will appear. it's no problem because they want to go off the standard way. |
I have just added 2 commits. |
80865d6
to
58ced25
Compare
@laco0416 I meant in the context of consumers of the library. However, you make a great point...this library is a plugin and peer dependencies fit plugins better since that way they can be dropped in more easily. I'll update the dependency type. |
@bernhard-niedermayer thank you for making the changes and thank you for your hard work on this! |
A new npm release will be created after I've updated README documentation to match NgModule-style inclusions. |
solves #47