Error: Unexpected value 'ToasterModule' imported by the module 'AppModule'

[robinkedia]

When compiling with @Angular/Compiler-cli it throws Error: Unexpected value 'ToasterModule' imported by the module 'AppModule'

Angular 2 RC6
ngc -p tsconfig.json

[Stabzs]

Could you please provide more context around this error or a working, reproducible example? Thanks

[dagstuan]

Can confirm this one. I have the same issue when I try to compile my project using AoT compilation. It seems Angular2-Toaster currently doesnt support AoT compiling. I'm not exactly sure why though.. will keep digging :)

[dagstuan]

I managed to get it to build by importing the source toaster.module.ts file instead of trying to import the one exported by the lib.

as in: import { ToasterModule } from 'angular2-toaster/src/toaster.module';.

So there seems to be something wrong with how the module is bundled that causes it to not get imported correctly by ngc.

[Stabzs]

@dagstuan Thanks for the confirmation and the investigative work.

I'll look into it.

[jcannata]

I am also having trouble with lazy-loaded routes but the error may point to the problem...

core.umd.js:5995 EXCEPTION: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

Looking at the code it looks like ToasterModule is importing BrowserModule where it probably should be importing CommonModule...

[Stabzs]

@jcannata That is a really good catch.

I didn't notice that BrowserModule was used during the code review for the ngModule contribution.

In hindsight, it makes perfect sense that this would be causing issues, since BrowserModule is needed for the entrance to the application, whereas CommonModule is needed for bootstrapping a plugin, which is what this is.

The library will always be dropped into another application for consumption. I'll take a close look at this locally. Thanks.

[Stabzs]

Is anyone able to confirm via getting latest source (not package) that the above commit has resolved this issue? I'd love confirmation before pushing a new npm package version.

Thanks.

[jcannata]

I have forked your code, 'link'ed it locally and confirmed that it solves the issue.

[Stabzs]

This is now published to NPM as 0.5.1-rc.6. Thanks @jcannata for the confirmation!!