-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hanging ngModule in container specs? #64
Comments
Yes, this is absolutely intended. This is the NgModule definition for the TestComponent class (hence the TestComponent declaration). Removing or modifying this will break the tests, as you found. |
The issue here is that there needed to be a declared exported class for TestComponent as well. |
Stabzs
added a commit
that referenced
this issue
Sep 16, 2016
The library has been updated to Angular `2.0.0` and the version has been bumped to `1.0.0` as a result. Closes #63. The library has been updated from tsd to typings. Typings have been updated and wired into the build and are now re-installed on `npm install`. In addition, typings are no longer checked into source. Closes #60. The main entrance has been updated to `angular2-toaster.js`. Addresses #60. The `bodyOutputType` property is public to enable AoT compilation on the template. Closes #62. The `TestComponent` module was improperly defined, causing errors in the corresponding `ngFactory` file. This has been corrected, closing #64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In toaster-container.component.spec.ts, after TestComponent class there seems to be a
@NgModule
decorator not attached to any class definition:Is that intended? While working at a PR to remove typings from source control, we incurred in a build error on toaster-container.component.spec.ngfactory.ts:
Not sure if it's due to this issue, though.
The text was updated successfully, but these errors were encountered: