add missing html attribute to interface description of toast #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is indeed a bug (good catch and thanks) but the resolution is both incomplete and (probably) incorrect. The argument being used should actually be the Also, please note that since this is fixing a use case that is currently untested (since code coverage can't inspect cases in templates, ugh), that this pull request should have been accompanied by additional tests that test this scenario. Thank you for bringing this to my attention. I'll fix it shortly. |
Stabzs
added a commit
that referenced
this pull request
May 31, 2016
The BodyOutputType.TrustedHtml option was trying to improperly render the toast.html property of the toast. This has been updated to render the body property as the inner html of the new toast instance and addresses #24. Body Output Type documentation added to the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the html attribute is used within toast.component.ts L15, but never declared and results within an compile error when using the TrustedHtml option with a typed Toast-Object