Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): re-create typings after install #65

Merged
merged 1 commit into from
Sep 16, 2016
Merged

chore(build): re-create typings after install #65

merged 1 commit into from
Sep 16, 2016

Conversation

BrainCrumbz
Copy link

Also:

  1. add clean npm script commands
  2. stop tracking typings directory
  3. avoid listing every single source file in tsconfig

Related to one of the topics in #60.

Also:

1. add clean npm script commands
1. stop tracking typings directory
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cddcfe1 on BrainCrumbz:chore/cleanup-typings into 56d040b on Stabzs:master.

@Stabzs
Copy link
Owner

Stabzs commented Sep 16, 2016

Thank you for making these changes. I was already in the process of making a number of these changes. The addition of rimraf is probably a well-deserved and overdue step.

@Stabzs Stabzs merged commit 8ca638b into Stabzs:master Sep 16, 2016
@BrainCrumbz BrainCrumbz deleted the chore/cleanup-typings branch September 16, 2016 08:05
@BrainCrumbz
Copy link
Author

I think you're doing a great job, also keeping up to date with all angular 2 RC updates until final, so yes, go on!

@Stabzs
Copy link
Owner

Stabzs commented Sep 16, 2016

@BrainCrumbz sorry for the revert, I was erring on the side of caution.

In the end, while it is nice to not have manual inclusion of files in tsconfig, it was breaking some of the dependencies for tests. I'll take another look at that later and update it accordingly since it is the better way to go.

In addition, a large number of the changes in this changeset were added in one form or another so thank you both again for the contribution!! It is appreciated! And glad you've found the library useful so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants