GET-CERTS: Bump github.com/go-acme/lego to v4 to resolve security issues with go-jose #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an older version of github.com/go-jose/go-jose Signed-off-by: Jauder Ho <[email protected]>
|
I've tested this solution in our staging area. That's not a complete test but it looks good so far. Thanks so much for pursuing this! I really appreciate it! |
tlimoncelli
changed the title
tlimoncelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve GHSA-c5q2-7r4c-mv6g and referenced in #1400.
I updated github.com/go-acme/lego to v4. There was an error thrown for https://github.com/StackExchange/dnscontrol/blob/main/pkg/acme/acme.go#L144 initially which was resolved by adding an additional blank string. I'm not 100% sure there is a specific reason that needs to be provided but did not see any such requirement when I looked further.
Fixing that results in a working build.