Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ubuntu 18.04 #269

Merged
merged 6 commits into from
Jul 27, 2020
Merged

Support for Ubuntu 18.04 #269

merged 6 commits into from
Jul 27, 2020

Conversation

gnewson
Copy link

@gnewson gnewson commented Jul 24, 2020

Resolves #249

st2mistral role has an added conditional so it doesn't run when on Ubuntu18.04. This is also applied to the postgresql role dependency.

Ubuntu18.04 added to the virtual machine list in the vagrant file and a small update to the readme to note that Ubuntu 18.04 is available as vagrant box.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Jul 24, 2020
@arm4b arm4b added the feature label Jul 24, 2020
@arm4b
Copy link
Member

arm4b commented Jul 24, 2020

Thanks for the contribution!
@amanda11 Assuming your experience with adding EL8, can you please help reviewing this PR?

@nmaludy
Copy link
Member

nmaludy commented Jul 24, 2020

Isn't mistral deprecated and not included in Ubuntu 18 because it is python 3 only (mistral doesn't support python3).

@amanda11
Copy link
Contributor

@armab yes I will review

@amanda11
Copy link
Contributor

@nmaludy I think that is what changes does - it's not installing mistral or postgres when Ubuntu 18.
Not reviewed thoroughly yet but the stackstorm.yml is omitting those roles and therefore their install by the looks

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Changes look good so far, I haven't checked the automated install script to check if any particular Ubuntu 18 v 16 script differences yet - in case any library changes for example. There were differences for redhat for python 3 that might also affect bionic - so it would be worth checking that (unless you have already).

However a few extra files to change. The.travis.yml controls what integrations are run and we should add Ubuntu 18 to this. Also the main/meta.yml and the meta.yml in each of the roles list the supported versions and need updating for bionic.

README.md Outdated
@@ -114,6 +114,7 @@ vagrant up

Other distros:
```sh
vagrant up ubuntu18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few more places to update, eg supported platforms, manual instructions, and list of deployments need to update

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll investigate and make those changes.

stackstorm.yml Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Jul 24, 2020
Vagrantfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Thanks @gnewson for the contribution and @amanda11 for review and pointers.

@arm4b arm4b merged commit 6a11a41 into StackStorm:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Ubuntu 18.04
4 participants