-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Ubuntu 18.04 #269
Conversation
Thanks for the contribution! |
Isn't mistral deprecated and not included in Ubuntu 18 because it is python 3 only (mistral doesn't support python3). |
@armab yes I will review |
@nmaludy I think that is what changes does - it's not installing mistral or postgres when Ubuntu 18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
Changes look good so far, I haven't checked the automated install script to check if any particular Ubuntu 18 v 16 script differences yet - in case any library changes for example. There were differences for redhat for python 3 that might also affect bionic - so it would be worth checking that (unless you have already).
However a few extra files to change. The.travis.yml controls what integrations are run and we should add Ubuntu 18 to this. Also the main/meta.yml and the meta.yml in each of the roles list the supported versions and need updating for bionic.
README.md
Outdated
@@ -114,6 +114,7 @@ vagrant up | |||
|
|||
Other distros: | |||
```sh | |||
vagrant up ubuntu18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a few more places to update, eg supported platforms, manual instructions, and list of deployments need to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll investigate and make those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #249
st2mistral role has an added conditional so it doesn't run when on Ubuntu18.04. This is also applied to the postgresql role dependency.
Ubuntu18.04 added to the virtual machine list in the vagrant file and a small update to the readme to note that Ubuntu 18.04 is available as vagrant box.