Describe why+how to build new stackstorm image #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
reviewed
Apr 30, 2018
images/stackstorm/Dockerfile
Outdated
| @@ -20,7 +20,10 @@ RUN DEBIAN_FRONTEND=noninteractive \ | |||
| crudini \ | |||
| uuid-runtime \ | |||
| apache2-utils \ | |||
| bash-completion | |||
| bash-completion \ | |||
| libkrb5-dev | |||
There was a problem hiding this comment.
Are you sure we should include any Ansible-required lib dependency in base Docker image?
There are a lot of other st2 integration packs which will require other libs as well during the pip install.
This is somewhat similar to StackStorm/st2-packages#241
I don't have an answer, but would like to hear opinions about pros/cons.
There was a problem hiding this comment.
Eek, no, that should not have been in the commit. Thanks for pointing out. It was part of my testing.. and slipped through the cracks at commit time.
There was a problem hiding this comment.
I agree - such dependencies should not be in the base Docker image.
arm4b
approved these changes
Apr 30, 2018
transhapHigsn
pushed a commit
to DiligenceVault/st2-docker
that referenced
this pull request
Jun 8, 2021
Describe why & how to build new stackstorm image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104.
I'd appreciate suggestions to how the description could be improved. Thanks!