Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.8 / Ubuntu Focal migration #54

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Conversation

jstaph
Copy link
Contributor

@jstaph jstaph commented Feb 12, 2022

A naive PR to migrate to Ubuntu Focal. I'm calling it naive, as I'm unfamiliar with what I should be doing to validate and verify the changes, but it seems to be working for me. Happy for feedback, suggestions, etc.

fixes #53

@arm4b arm4b added enhancement New feature or request maintenance labels Feb 12, 2022
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice!

Thanks a lot for covering all the places in Dockerfiles 👍

@jstaph Could you also prepare the PRs in docker and K8s repos with the changelog update?
https://github.com/stackStorm/st2-docker/
https://github.com/StackStorm/stackstorm-ha/
And so we could merge them during the next st2 release when the focal docker changes will be promoted to stable.

@arm4b arm4b merged commit 1dac04d into StackStorm:master Feb 12, 2022
@jstaph
Copy link
Contributor Author

jstaph commented Feb 13, 2022

Much appreciated! I'll get you PR's for the other repos.

Thanks again for the merge, and the compliment!

@jstaph jstaph deleted the ubuntu_20 branch February 13, 2022 01:52
@rite2hhh
Copy link

rite2hhh commented Aug 1, 2022

@armab

Did this make into StackStorm v3.7?

I don't see the changelog entry (https://github.com/StackStorm/st2-docker/pull/238/files)
for either st2 v3.7 or latest version at https://docs.stackstorm.com/latest/changelog.html.

It's unclear based on the changelog date 2022-05-06 (a day after v3.7 release) vs when the
changes were actually committed (Feb 12)

@arm4b
Copy link
Member

arm4b commented Aug 2, 2022

@rite2hhh Yes, it's part of the v3.7 Docker images (https://github.com/StackStorm/st2-dockerfiles/blob/v3.7/base/Dockerfile#L1)

The deployment methods like Ansible, Puppet, Docker, or K8s live separated from stackstorm core with their own Changelog.

@rite2hhh
Copy link

rite2hhh commented Aug 2, 2022

@armab, thanks for the information, this helps!

@frankpengau
Copy link

@armab Thanks for confirming. I wasn't sure that it made it into the stackstorm v3.7 release as well. This helps a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Ubuntu18 (py3.6) -> Ubuntu20 (py3.8)
4 participants