-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 5060 upgrade virtualenv to latest (20.2.2) #5094
Conversation
You need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! That's a good start.
Besides of feedback @blag provided, there are more places where pip, virtualenv versions are pinned.
Let's update them too. Here are the pointers:
Lines 398 to 402 in e5131b8
# NOTE We need to upgrade setuptools to avoid bug with dependency resolving in old versions # Setuptools 42 added support for python_requires, which is used by the configparser package, # which is required by the importlib-metadata package $(VIRTUALENV_ST2CLIENT_DIR)/bin/pip install --upgrade "pip==$(PIP_VERSION)" $(VIRTUALENV_ST2CLIENT_DIR)/bin/pip install --upgrade "setuptools==44.1.0" Lines 535 to 537 in e5131b8
# setuptools >= 41.0.1 is required for packs.install in dev envs # setuptools >= 42 is required so setup.py install respects dependencies' python_requires $(VIRTUALENV_DIR)/bin/pip install --upgrade "setuptools==44.1.0" - Every
Dockerfile
in thest2packaging-dockerfiles
repository, like: https://github.com/StackStorm/st2packaging-dockerfiles/blob/master/packagingbuild/xenial/Dockerfile#L50-L51
7c96b38
to
545fc71
Compare
StackStorm/st2packaging-dockerfiles#97 i need to upgrade this PR to latest and resolve conflicts before reviewing |
545fc71
to
c045750
Compare
It looks like Travis timed out |
Tried to resolve conflicts, so can see if we can merge before release freeze. Note cannot update PIP_VERSION variable to 20.3.3 as make requirements then fails, it is known that there are issues with the changes that affects make requirements. So left that as the previous version. |
Remove commented out line to trigger a new Travis run.
#5060 #5036