-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of st2mistral from basic chapter of docs #1011
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
46ac0e7
Removal of st2mistral from basic chapter of docs
amanda11 48f37fd
Minor language changes & tidy
LindsayHill 81243a6
small language change
LindsayHill 74d3e37
Another small language change
LindsayHill 555ad2d
Merge branch 'master' into remove_mistral_basic
amanda11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,44 @@ | ||
.. NOTE: This file has been generated automatically, don't manually edit it | ||
.. NOTE: This file has been generated automatically, don't manually edit it. | ||
Edit st2common/st2common/constants/triggers.py and rebuild the | ||
documentation. | ||
Action | ||
~~~~~~ | ||
|
||
+---------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| Reference | Description | Properties | | ||
+===========================+=================================================================+=============================================================================================================+ | ||
| st2.generic.actiontrigger | Trigger encapsulating the completion of an action execution. | execution_id, status, start_timestamp, action_name, action_ref, runner_ref, parameters, result | | ||
+---------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| st2.generic.notifytrigger | Notification trigger. | execution_id, status, start_timestamp, end_timestamp, action_ref, runner_ref, channel, route, message, data | | ||
+---------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| st2.action.file_writen | Trigger encapsulating action file being written on disk. | ref, file_path, host_info | | ||
+---------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| st2.generic.inquiry | Trigger indicating a new "inquiry" has entered "pending" status | id, route | | ||
+---------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
+--------------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| Reference | Description | Properties | | ||
+================================+=================================================================+=============================================================================================================+ | ||
| core.st2.generic.actiontrigger | Trigger encapsulating the completion of an action execution. | execution_id, status, start_timestamp, action_name, action_ref, runner_ref, parameters, result | | ||
+--------------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| core.st2.generic.notifytrigger | Notification trigger. | execution_id, status, start_timestamp, end_timestamp, action_ref, runner_ref, channel, route, message, data | | ||
+--------------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| core.st2.action.file_written | Trigger encapsulating action file being written on disk. | ref, file_path, host_info | | ||
+--------------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
| core.st2.generic.inquiry | Trigger indicating a new "inquiry" has entered "pending" status | id, route | | ||
+--------------------------------+-----------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------+ | ||
|
||
Sensor | ||
~~~~~~ | ||
|
||
+--------------------------+--------------------------------------------------+------------+ | ||
| Reference | Description | Properties | | ||
+==========================+==================================================+============+ | ||
| st2.sensor.process_spawn | Trigger indicating sensor process is started up. | object | | ||
+--------------------------+--------------------------------------------------+------------+ | ||
| st2.sensor.process_exit | Trigger indicating sensor process is stopped. | object | | ||
+--------------------------+--------------------------------------------------+------------+ | ||
+-------------------------------+--------------------------------------------------+------------+ | ||
| Reference | Description | Properties | | ||
+===============================+==================================================+============+ | ||
| core.st2.sensor.process_spawn | Trigger indicating sensor process is started up. | object | | ||
+-------------------------------+--------------------------------------------------+------------+ | ||
| core.st2.sensor.process_exit | Trigger indicating sensor process is stopped. | object | | ||
+-------------------------------+--------------------------------------------------+------------+ | ||
|
||
Key Value Pair | ||
~~~~~~~~~~~~~~ | ||
|
||
+---------------------------------+---------------------------------------------------------+------------------------+ | ||
| Reference | Description | Properties | | ||
+=================================+=========================================================+========================+ | ||
| st2.key_value_pair.create | Trigger encapsulating datastore item creation. | object | | ||
+---------------------------------+---------------------------------------------------------+------------------------+ | ||
| st2.key_value_pair.update | Trigger encapsulating datastore set action. | object | | ||
+---------------------------------+---------------------------------------------------------+------------------------+ | ||
| st2.key_value_pair.value_change | Trigger encapsulating a change of datastore item value. | old_object, new_object | | ||
+---------------------------------+---------------------------------------------------------+------------------------+ | ||
| st2.key_value_pair.delete | Trigger encapsulating datastore item deletion. | object | | ||
+---------------------------------+---------------------------------------------------------+------------------------+ | ||
+--------------------------------------+---------------------------------------------------------+------------------------+ | ||
| Reference | Description | Properties | | ||
+======================================+=========================================================+========================+ | ||
| core.st2.key_value_pair.create | Trigger encapsulating datastore item creation. | object | | ||
+--------------------------------------+---------------------------------------------------------+------------------------+ | ||
| core.st2.key_value_pair.update | Trigger encapsulating datastore set action. | object | | ||
+--------------------------------------+---------------------------------------------------------+------------------------+ | ||
| core.st2.key_value_pair.value_change | Trigger encapsulating a change of datastore item value. | old_object, new_object | | ||
+--------------------------------------+---------------------------------------------------------+------------------------+ | ||
| core.st2.key_value_pair.delete | Trigger encapsulating datastore item deletion. | object | | ||
+--------------------------------------+---------------------------------------------------------+------------------------+ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the example used in the unit-tests, but I couldn't get notify in Orquesta working in my setup - but I may be missing something. In the Orquesta pages we just mention there is a notify parameter that we can ignore for now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got Orquesta notifications working but I also had to add on a notify section as well as the notify parameters, e.g. I also had:
so that it had the details of route etc.
Do we think the documentation as is is ok, or
The method for specify the route and conditions for when tasks in an Orquesta workflow is the same as ActionChain. You have a notify section in the action meta when registering.
and should I put in a notify section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LindsayHill @armab Having got notifications working in Orquesta now, I'm wondering if more needs to go into this
section on the chatops page. Or alternatively I was mis-understanding something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So as not to confuse things, I will merge this PR. And generate a new PR with enhancements that I think will make Orquesta notifications even clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 step by step