Update Ingress to include st2web service name #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `{{ .Release.Name }}-ingress` is not informing enough and causes a problem when using `stackstorm-ha` as a dependency for another chart. Helm creates the ingress resource as `{{ .Release.Name }}-ingress` but it's not the ingress of the current chart. This would make the ingress resource of `stackstorm-ha` more definitive.
pull-request-size
bot
added
the
size/XS
arm4b
suggested changes
Feb 16, 2020
Using `{{ .Release.Name }}-ingress` is not informing enough and causes a problem when using `stackstorm-ha` as a dependency for another chart. Helm creates the ingress resource as `{{ .Release.Name }}-ingress` but it's not the ingress of the current chart. This would make the ingress resource of `stackstorm-ha` more definitive
arm4b
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
{{ .Release.Name }}-ingressis not informing enough and causes a problem when usingstackstorm-haas a dependency for another chart. Helm creates the ingress resource as{{ .Release.Name }}-ingressbut it's not the ingress of the current chart. This would make the ingress resource ofstackstorm-hamore definitive.