Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pullPolicy to "IfNotPresent", as Docker-Hub Ratelimits now #159

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Change pullPolicy to "IfNotPresent", as Docker-Hub Ratelimits now #159

merged 1 commit into from
Nov 20, 2020

Conversation

moonrail
Copy link
Contributor

Hello altogether

Docker-Hub introduced Ratelimiting: https://docs.docker.com/docker-hub/download-rate-limit/

While testing you will pull images a lot, also you may not want to always pull images, even on dev environments.

So I've figured, this would be a better default for most users.

Please let me know, if there is something to improve. :)

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Nov 20, 2020
arm4b
arm4b suggested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This helps 👍

Looks good, just let's change the defaults for st2 images without touching the upstream chart settings as they already have pullPolicy: IfNotPresent.

We'll also need a respective CHANGELOG record for this PR.

values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
@arm4b arm4b added the enhancement New feature or request label Nov 20, 2020
@pull-request-size pull-request-size bot added size/XS PR that changes 0-9 lines. Quick fix/merge. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Nov 20, 2020
@moonrail
Copy link
Contributor Author

@armab
Makes perfectly sense to use upstream chart defaults - removed hardcoded pullPolicies for them.

arm4b
arm4b reviewed Nov 20, 2020
View reviewed changes
values.yaml Outdated Show resolved Hide resolved
arm4b
arm4b approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks a lot!

@arm4b arm4b merged commit 7821795 into StackStorm:master Nov 20, 2020
@moonrail moonrail deleted the set_image_pull_policy_to_sane branch November 20, 2020 15:41
@moonrail moonrail mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moonrail @arm4b