Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added resource Requests values for St2 Pods #179

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Added resource Requests values for St2 Pods #179

merged 2 commits into from
Feb 17, 2021

Conversation

arms11
Copy link
Contributor

@arms11 arms11 commented Feb 14, 2021 •
edited by arm4b
Loading

Closes #5
The values are added based on production monitoring average base on during peak/off-peak hours.
Please note: While I have not been able to test this in minikube due to unrelated reasons, below is the resource utilization of the 3 nodes cluster with t3.large (2 CPUs/8GB Memory) spec.

NAME                             CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
ip-192-168-137-84.ec2.internal   428m         22%    2587Mi          36%
ip-192-168-171-99.ec2.internal   279m         14%    3048Mi          42%
ip-192-168-99-86.ec2.internal    237m         12%    2640Mi          37%

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Feb 14, 2021
@arms11
Copy link
Contributor Author

arms11 commented Feb 14, 2021

@armab - Please review/guide. Thanks.

arm4b
arm4b reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the data here based on using the StackStorm-HA cluster in production 👍

Please also add a Changelog record and we should be good to go!

@arm4b arm4b added the enhancement New feature or request label Feb 15, 2021
@arms11 arms11 force-pushed the resource-requests-spec-for-st2-pods branch from e67476b to 954ee4b Compare February 15, 2021 20:39
@arms11 arms11 marked this pull request as ready for review February 15, 2021 20:56
@arms11
Copy link
Contributor Author

arms11 commented Feb 15, 2021

Added Changelog entry and opened the pull request. Thanks.

arm4b
arm4b approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked well! 👍

Thanks for sharing the st2 pod usage data from the prod environment and codifying it here.
Tha'll help with proper resource allocation and scheduling in the wild.

@arm4b arm4b merged commit 097d4f7 into StackStorm:master Feb 17, 2021
@arm4b arm4b mentioned this pull request Feb 17, 2021
Merged
@arm4b arm4b mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find resource Requests for all K8s pods/deployments
2 participants
@arms11 @arm4b