Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis.staticID feature to allow constant sentinel ids #191

Merged
merged 6 commits into from
Apr 29, 2021

Conversation

manisha-tanwar
Copy link
Contributor

Redis sentinel not able to elect master & all pods goes into CrashLoopBackOff when worker nodes are rebooted or 2 pods crashes for any reason.
helm/charts#19059

Redis sentinel not able to elect master & all pods goes into CrashLoopBackOff when worker nodes are rebooted or 2 pods crashes for any reason.
helm/charts#19059
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Apr 29, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
The change looks good to me overall.

I provided one minor comment and we'll also need a Changelog.md update to merge this.

values.yaml Show resolved Hide resolved
@arm4b arm4b added the enhancement New feature or request label Apr 29, 2021
After 2 redis pods failure or if worker nodes are restarted, sentinel not able to elect master.

This feature was added with PR: helm/charts#19059

Sentinels never forget about replicas of a given master, even when they are unreachable for a long time.
In Kubernetes, unless specified, each pod is given a random IP. In our case, with 2 slaves and one master, each replicas is attributed to a random IP. Holding on to old replicas IPs will only make it impossible for other sentinels to elect a new master. constant sentinel ID will allow other sentinel peers to update to the new given IP.
CHANGELOG.md Outdated Show resolved Hide resolved
@manisha-tanwar manisha-tanwar changed the title Update redis sentinel.staticID: true Add redis.staticID feature to allow constant sentinel ids Apr 29, 2021
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Apr 29, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks! 👍

@arm4b arm4b merged commit 31e0171 into StackStorm:master Apr 29, 2021
@manisha-tanwar manisha-tanwar deleted the patch-2 branch April 29, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants