-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redis.staticID feature to allow constant sentinel ids #191
Conversation
Redis sentinel not able to elect master & all pods goes into CrashLoopBackOff when worker nodes are rebooted or 2 pods crashes for any reason. helm/charts#19059
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
The change looks good to me overall.
I provided one minor comment and we'll also need a Changelog.md update to merge this.
After 2 redis pods failure or if worker nodes are restarted, sentinel not able to elect master. This feature was added with PR: helm/charts#19059 Sentinels never forget about replicas of a given master, even when they are unreachable for a long time. In Kubernetes, unless specified, each pod is given a random IP. In our case, with 2 slaves and one master, each replicas is attributed to a random IP. Holding on to old replicas IPs will only make it impossible for other sentinels to elect a new master. constant sentinel ID will allow other sentinel peers to update to the new given IP.
Update CHANGELOG.md
Move new change to "In Development"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks! 👍
Redis sentinel not able to elect master & all pods goes into CrashLoopBackOff when worker nodes are rebooted or 2 pods crashes for any reason.
helm/charts#19059