Refactor: Use helper for st2-config-vol volume/volumeMounts definitions #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
force-pushed
the
st2-conf-helper
branch
4 times, most recently
from
cc16fe1
to
d330e35
Compare
|
pull-request-size bot says that this PR is ---
apiVersion: ...
kind: ...
metadata:
...
spec:
template:
metadata:
...
spec:
...
containers:
- name: ...
...
volumeMounts:
- - name: st2-config-vol
- mountPath: /etc/st2/st2.docker.conf
- subPath: st2.docker.conf
- - name: st2-config-vol
- mountPath: /etc/st2/st2.user.conf
- subPath: st2.user.conf
+ {{- include "st2-config-volume-mounts" . | nindent 8 }}
volumes:
- - name: st2-config-vol
- configMap:
- name: {{ .Release.Name }}-st2-config
+ {{- include "st2-config-volume" . | nindent 8 }}And then the template definition is just: |
|
This seems like a great change. |
cognifloyd
force-pushed
the
st2-conf-helper
branch
from
d330e35
to
06ce553
Compare
|
rebased on master |
cognifloyd
force-pushed
the
st2-conf-helper
branch
from
18de1fe
to
d8e51c4
Compare
|
rebased on master |
cognifloyd
force-pushed
the
st2-conf-helper
branch
from
d8e51c4
to
035802d
Compare
cognifloyd
changed the title
cognifloyd
force-pushed
the
st2-conf-helper
branch
2 times, most recently
from
1c538d4
to
3a2ee8d
Compare
ericreeves
approved these changes
Jul 3, 2021
cognifloyd
force-pushed
the
st2-conf-helper
branch
3 times, most recently
from
d0f6fcb
to
75ff9cd
Compare
|
@armab This one is the next easiest PR to review. Please and thank you! |
This reduces duplication.
cognifloyd
force-pushed
the
st2-conf-helper
branch
from
75ff9cd
to
5afe550
Compare
|
Tests are green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces duplication of the st2-config-vol definitions in
volumes:andvolumeMounts:blocks.