Fix stanley_rsa permissions via postStart pod lifecycle hook #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
cognifloyd
force-pushed
the
stanley_rsa-permissions
branch
from
7ddca4a
to
0a87e8a
Compare
Add chown command to postStart lifecycle hook for actionrunner and st2client pods
cognifloyd
force-pushed
the
stanley_rsa-permissions
branch
from
0a87e8a
to
a6e4ab1
Compare
This was referenced Jul 8, 2021
arm4b
reviewed
Jul 10, 2021
| @@ -52,6 +52,18 @@ load "${BATS_HELPERS_DIR}/bats-file/load.bash" | |||
| assert_line --partial 'succeeded: true' | |||
| } | |||
|
|
|||
| @test 'stanley_rsa file has correct permissions and ownership' { | |||
arm4b
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted this change from #206.
Use the postStart lifecycle event in st2actionrunner and st2client pods to correct file permissions on the stanley ssh private key.
Includes a test to ensure the key permissions are correct.
see:
https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/
Fixes #84