Do not include default rbac files in values #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As values dictionaries are merged, there is no way to remove unwanted rbac files like sample.yaml. And, we cannot assume that st2admin and stanley are present, because those are configurable. So, do not include any sample/default rbac files in values.
pull-request-size
bot
added
the
size/M
This was referenced Sep 12, 2021
|
I would prefer using #248 to avoid changing the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As values dictionaries are merged, there is no way to remove unwanted rbac files like sample.yaml. And, we cannot assume that st2admin and stanley are present, because those are configurable. So, do not include any sample/default rbac files in values.
Resolves #230
Closes #248 (alternative implementation)