Allow st2web to serve HTTPS #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone enables https, they need to provide certs via extra_volumes
pull-request-size
bot
added
the
size/S
ericreeves
approved these changes
Nov 15, 2021
arm4b
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
I thought about discussing more the approach in this PR as we've removed it before in favor of LoadBalancer or Ingress Controller which is more K8s native and flexible.
Because we have this functionality still present in the Docker images and enabling it really easy, - let's do it!
Thanks for the PR 👍
pull-request-size
bot
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker image allows serving HTTPS when environment var
ST2WEB_HTTPS=1. SettingST2WEB_HTTPS: "1"inst2web.env, however, breaks thest2webk8s deployment & service because thelivenessProbeand the service are still trying to access HTTP on port 80.To make
ST2WEB_HTTPS=1work correctly, 2 things are required:ST2WEB_HTTPS=1.extra_volumes(like several other deployments) so users can mount ssl certs that they provide. Managing any kubernetes secrets for those certs is out-of-scope for this chart, similar to anything else provided viaextra_volumes.This PR makes those changes, but retains the current HTTP-by-default behavior.
Closes: #236