Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue with register content when configuring volumes #324

Merged

Conversation

rebrowning
Copy link
Contributor

@rebrowning rebrowning commented Jul 16, 2022

add the additional check to the condition, since what is happening is the container is attempting to run but the st2-pack-configs-from-helm-vol is not being created because the condition is not met

I've been digging in to try and understand what the init containers are doing, but the root of the problem is the init container is expecting a volume that doesn't exist as part of the pod as part of a condition, so I simply added the condition to the init container causing the issue.

If there's a better way to resolve it please let me know and I'll take a look.

Fixes #320

… the container is attempting to run but the st2-pack-configs-from-helm-vol is not being created because the condition is not met
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jul 16, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2022

CLA assistant check
All committers have signed the CLA.

@cognifloyd
Copy link
Member

Wow! Good find. Yeah, that's clearly a bug.

@cognifloyd
Copy link
Member

So, we have unit tests for a lot of the chart, but not for the init containers. helm-unittest requires an index instead of a container name which makes it far too brittle to write unit tests. So, the only way to identify init container bugs is manually. Thank you for finding this! I'll merge it once tests pass.

@cognifloyd cognifloyd added bug Something isn't working Helm labels Jul 16, 2022
@cognifloyd cognifloyd merged commit 4938df9 into StackStorm:master Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Helm size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with pvc volume mount on job-st2-register-content
3 participants