fix for the redis password not being set in the connection string #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
rebrowning
changed the title
cognifloyd
approved these changes
Aug 9, 2022
|
Hi @rebrowning I am one of the users who uses the sub-chart. As long as you have tested the deployment without password and it works, I think it's a good change. We want to make sure it's backward compatible. Could you please confirm? |
|
@arms11 I tested both with and without a password configuration for Redis when doing this. I'm more than happy to provide a couple screenshots after hours of the config/template/deployment success for completeness. |
|
Nope. I appreciate the response. |
|
Please also add a changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like some feedback on how we want to handle this.
There are other options with how to configure redis in the underlying bitnami chart (generated password, secretfile). However I don't know how to grab either the generated helm value or the value from the secret file to then inject it into the redis url. Are there some additional coordination parameters we can use in st2 to set the password or an environment variable that st2 will consume for the redis password?
Additionally, you can set sentinel to be protected by the same password as well, however this
DOES NOTwork due to the tooz driver not populating the password for the sentinel client, only for the redis client that gets created from the sentinel get master request.