Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix st2web re-deployment is not triggered when updating SSL cert #33

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Fix st2web re-deployment is not triggered when updating SSL cert #33

merged 2 commits into from
Nov 7, 2018

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Nov 6, 2018

Update of Helm values secrets.st2web. for SSL certificate doesn't trigger st2web re-deployment.

This PR fixes it so st2web deployment depends on SSL cert secret checksum via annotations.

@arm4b arm4b added bug Something isn't working RFR labels Nov 6, 2018
@arm4b arm4b requested a review from warrenvw November 6, 2018 20:51
@arm4b arm4b added this to the st2cicd (pre-v3.0) milestone Nov 6, 2018
warrenvw
warrenvw approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@warrenvw warrenvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arm4b arm4b merged commit 5dcac08 into master Nov 7, 2018
@arm4b arm4b deleted the fix/st2web-ssl-cert-update branch November 7, 2018 21:09
@cognifloyd cognifloyd removed the RFR label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrenvw warrenvw warrenvw approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
st2cicd (pre-GA)
Development

Successfully merging this pull request may close these issues.
3 participants
@arm4b @warrenvw @cognifloyd