allow datastore secret name to be specified #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pull-request-size
bot
added
the
size/M
guzzijones
force-pushed
the
datastore
branch
2 times, most recently
from
79f06eb
to
1375c7d
Compare
fix false being cast to boolean fix var assignment
guzzijones
changed the title
|
Any thoughts on this? |
cognifloyd
requested changes
Mar 12, 2023
There was a problem hiding this comment.
I think we're going to need to do something like this for many of our secrets.
What about adding a helper that returns the name of the secret to use? That can handle returning the custom secret name if provided, or else the default name. Use that helper in the be deployments and jobs.
Then, in the secret file, wrap the whole resource in an if block. If there is a custom resource name, do not create the chart-managed secret.
|
Something like #359 would be great for the datastore secret. |
|
I am going to start on this with the changes you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow a datastore secret name to be specified. If one is specified do not dynamically generate a new datastore secret.
If I uninstall and reinstall this helm chart a new secret is generated.
Sometimes a helm upgrade isn't enough. In that case I do an uninstall and reinstall. This seems to be the case for ingress changes.