Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add external secret for datastore encryption #366

Merged
merged 4 commits into from
May 22, 2023

Conversation

guzzijones
Copy link
Contributor

add an external secret check to values.yaml to allow for secret to be stored outside of helm chart.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label May 15, 2023
@CLAassistant
Copy link

CLAassistant commented May 15, 2023

CLA assistant check
All committers have signed the CLA.

@guzzijones
Copy link
Contributor Author

The helm-unittest has an invalid argument --helm3

@cognifloyd
Copy link
Member

Well ok then. Apparently, the helm-unittest fork we've been using is not the primary one any more 🤦 . helm-unittest/helm-unittest#102

OK. So, we need to switch to helm-unittest/helm-unittest but there are breaking changes that mean we have to change the cli arg (as you noticed) and some of our tests. One good thing is that the new version supports JSONPath, so we might be able to use names instead of indexes to verify things which will make our unit tests much less obtuse.

I'm not prepared to tackle all of that right now, so maybe we can pin a version on the old fork for the time being. Could you try changing https://github.com/StackStorm/stackstorm-k8s/blob/master/.github/workflows/unit.yaml#LL38C31-L38C72 like this:

-          helm plugin install https://github.com/quintush/helm-unittest
+          helm plugin install https://github.com/quintush/helm-unittest --version v0.2.11

@cognifloyd cognifloyd enabled auto-merge May 22, 2023 20:44
@cognifloyd cognifloyd merged commit f49658a into StackStorm:master May 22, 2023
@bmarick
Copy link
Contributor

bmarick commented Jul 18, 2023

@cognifloyd - Any chance you can do a release so this can be available at https://helm.stackstorm.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants