fix: PVC should use claimName key
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `claim-name` for persistent pack volumes, the following error is raised by Helm: ``` > helm upgrade my-st2 stackstorm/stackstorm-ha --values values.yaml --debug upgrade.go:144: [debug] preparing upgrade for my-st2 Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(Deployment.spec.template.spec.volumes[2].persistentVolumeClaim): unknown field "claim-name" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[2].persistentVolumeClaim): missing required field "claimName" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[3].persistentVolumeClaim): unknown field "claim-name" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[3].persistentVolumeClaim): missing required field "claimName" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[4].persistentVolumeClaim): unknown field "claim-name" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[4].persistentVolumeClaim): missing required field "claimName" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource] ``` Fix by using `claimName` instead for `persistentVolumeClaim` sections.
pull-request-size
bot
added
the
size/XS
|
|
arm4b
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
claim-namefor persistent pack volumes, the following error is raised by Helm:Fix by using
claimNameinstead forpersistentVolumeClaimsections.