[refactor] refactoring code to remove duplicate code #152
Conversation
Signed-off-by: yandongxiao <[email protected]>
| @@ -1064,7 +1064,7 @@ spec: | |||
| type: object | |||
| type: array | |||
| image: | |||
| description: Image for a starrocks be deployment. | |||
| description: Image for a starrocks deployment.. | |||
| } | ||
|
|
||
| // StarRocksCnSpec defines the desired state of cn. | ||
| type StarRocksCnSpec struct { |
There was a problem hiding this comment.
may still needs StorageVolumes for CN, e.g, mount volumes for log or for cache
| // to be owned by the pod: | ||
| FsGroup *int64 `json:"fsGroup,omitempty"` | ||
|
|
||
| //Replicas is the number of desired Pod, the number is 1,3,5 |
There was a problem hiding this comment.
the number is 1,3,5 is misleading, remove it.
| } | ||
|
|
||
| func (spec *StarRocksBeSpec) GetStorageVolumes() []StorageVolume { | ||
| return spec.StorageVolumes |
There was a problem hiding this comment.
when need to check if the spec is nil, when not needed? what's the criteria?
There was a problem hiding this comment.
This is a very good question! Currently, although there is no check for whether spec *StarRocksBeSpec is nil, the SubController, during reconciling, will first verify if their respective Spec is nil.
| }, | ||
| { | ||
| Name: "USER", | ||
| Value: "root", |
There was a problem hiding this comment.
// TODO: make this configurable.
There was a problem hiding this comment.
So, USER==root is its default value?
There was a problem hiding this comment.
yes, I mean add a TODO here, we will soon go back here to support non-root mode.
…difications to the code. Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
feature/refactor-code
branch
from
283adb3
to
9e25fe5
Compare
|
I have submitted a new commit based on the feedback provided in the review above. |
No description provided.