Feature/ensure pods restart when configmap changes #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f) changes Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
feature/ensure-pods-restart-when-configmap-changes
branch
from
8c6d6e7
to
e9b4a5e
Compare
kevincai
reviewed
Jul 6, 2023
kevincai
reviewed
Jul 6, 2023
| the first 8 digits are taken, which will be used as the annotations for pods. | ||
| */}} | ||
| {{- define "starrockscluster.fe.config.hash" }} | ||
| {{- $hash := toJson .Values.starrocksFESpec.config | sha256sum | trunc 8 }} |
There was a problem hiding this comment.
what if user provided an empty fe/be/cn config? will this be still ok?
Signed-off-by: yandongxiao <[email protected]>
kevincai
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.