[bugfix] fix some bugs #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yandongxiao
commented
Jul 12, 2023
yandongxiao
commented
- reuse api.md and its script, because it is linked in StarRocks Doc
- delete namespace.yaml, otherwise helm install will failed.
- use resources not resource in values.yaml
1. reuse api.md and its script, because it is linked in StarRocks Doc 2. delete namespace.yaml, otherwise helm install will failed. 3. use resources not resource in values.yaml Signed-off-by: yandongxiao <[email protected]>
Signed-off-by: yandongxiao <[email protected]>
Signed-off-by: yandongxiao <[email protected]>
kevincai
reviewed
Jul 12, 2023
| @@ -274,7 +274,7 @@ starrocksCnSpec: | |||
| # scaleDown: | |||
| # selectPolicy: Disabled | |||
| # define resources requests and limits for cn pods. | |||
| resource: | |||
| resources: | |||
There was a problem hiding this comment.
could cause compatible issue when the user upgrade from previous chart version to this, without updating its values.yaml?
There was a problem hiding this comment.
yes, This is a problem. But this misspell should be fixed.
So, we both support resources and resource?
There was a problem hiding this comment.
yes, please. recommends the right spelling, but can still work if mis-spelled for now, possibly generating a warning message? can possibly remove the support after 2-3 releases in future.
Signed-off-by: yandongxiao <[email protected]>
kevincai
reviewed
Jul 12, 2023
| {{- end }} | ||
| {{- if .Values.starrocksFESpec.resources }} | ||
| {{- toYaml .Values.starrocksFESpec.resources | nindent 4 }} | ||
| {{- else if .Values.starrocksFESpec.resource }} |
There was a problem hiding this comment.
does helm chart template support comments? shall add comments here to explain why if-else if here.
Signed-off-by: yandongxiao <[email protected]>
kevincai
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.