Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] add runAsNonRoot filed #195

Merged
merged 5 commits into from
Jul 27, 2023
Merged

[Feature] add runAsNonRoot filed #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1a02fc
[Feature] add runAsNonRoot filed
yandongxiao Jul 26, 2023
ba9abda
update comment on RunAsNonRoot field
yandongxiao Jul 26, 2023
3b128e3
remove fsGroup field
yandongxiao Jul 26, 2023
7d1c2f8
add FSGroup field in pod securityContext
yandongxiao Jul 27, 2023
aa3aa04
Update pkg/k8sutils/templates/pod/spec.go
yandongxiao Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 18 additions & 36 deletions config/crd/bases/starrocks.com_starrocksclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,12 +1056,6 @@ spec:
type: string
type: object
type: array
fsGroup:
description: 'A special supplemental group that applies to all
containers in a pod. Some volume types allow the Kubelet to
change the ownership of that volume to be owned by the pod:'
format: int64
type: integer
hostAliases:
description: HostAliases is an optional list of hosts and IPs
that will be injected into the pod's hosts file if specified.
Expand Down Expand Up @@ -1168,6 +1162,12 @@ spec:
it defaults to Limits if that is explicitly specified, otherwise
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
runAsNonRoot:
description: 'RunAsNonRoot is used to determine whether to run
starrocks as a normal user. If RunAsNonRoot is true, operator
will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil'
type: boolean
schedulerName:
description: SchedulerName is the name of the kubernetes scheduler
that will be used to schedule the pods.
Expand Down Expand Up @@ -3000,12 +3000,6 @@ spec:
type: string
type: object
type: array
fsGroup:
description: 'A special supplemental group that applies to all
containers in a pod. Some volume types allow the Kubelet to
change the ownership of that volume to be owned by the pod:'
format: int64
type: integer
hostAliases:
description: HostAliases is an optional list of hosts and IPs
that will be injected into the pod's hosts file if specified.
Expand Down Expand Up @@ -3112,6 +3106,12 @@ spec:
it defaults to Limits if that is explicitly specified, otherwise
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
runAsNonRoot:
description: 'RunAsNonRoot is used to determine whether to run
starrocks as a normal user. If RunAsNonRoot is true, operator
will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil'
type: boolean
schedulerName:
description: SchedulerName is the name of the kubernetes scheduler
that will be used to schedule the pods.
Expand Down Expand Up @@ -4270,12 +4270,6 @@ spec:
- name
type: object
type: array
fsGroup:
description: 'A special supplemental group that applies to all
containers in a pod. Some volume types allow the Kubelet to
change the ownership of that volume to be owned by the pod:'
format: int64
type: integer
hostAliases:
description: HostAliases is an optional list of hosts and IPs
that will be injected into the pod's hosts file if specified.
Expand Down Expand Up @@ -4382,6 +4376,12 @@ spec:
it defaults to Limits if that is explicitly specified, otherwise
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
runAsNonRoot:
description: 'RunAsNonRoot is used to determine whether to run
starrocks as a normal user. If RunAsNonRoot is true, operator
will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil'
type: boolean
schedulerName:
description: SchedulerName is the name of the kubernetes scheduler
that will be used to schedule the pods.
Expand Down Expand Up @@ -5706,12 +5706,6 @@ spec:
description: the config response key in configmap.
type: string
type: object
fsGroup:
description: 'A special supplemental group that applies to all
containers in a pod. Some volume types allow the Kubelet to
change the ownership of that volume to be owned by the pod:'
format: int64
type: integer
hostAliases:
description: HostAliases is an optional list of hosts and IPs
that will be injected into the pod's hosts file if specified.
Expand Down Expand Up @@ -7614,12 +7608,6 @@ spec:
description: the config response key in configmap.
type: string
type: object
fsGroup:
description: 'A special supplemental group that applies to all
containers in a pod. Some volume types allow the Kubelet to
change the ownership of that volume to be owned by the pod:'
format: int64
type: integer
hostAliases:
description: HostAliases is an optional list of hosts and IPs
that will be injected into the pod's hosts file if specified.
Expand Down Expand Up @@ -8814,12 +8802,6 @@ spec:
- name
type: object
type: array
fsGroup:
description: 'A special supplemental group that applies to all
containers in a pod. Some volume types allow the Kubelet to
change the ownership of that volume to be owned by the pod:'
format: int64
type: integer
hostAliases:
description: HostAliases is an optional list of hosts and IPs
that will be injected into the pod's hosts file if specified.
Expand Down
24 changes: 6 additions & 18 deletions deploy/starrocks.com_starrocksclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,9 +477,6 @@ spec:
type: string
type: object
type: array
fsGroup:
format: int64
type: integer
hostAliases:
items:
properties:
Expand Down Expand Up @@ -549,6 +546,8 @@ spec:
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
type: object
runAsNonRoot:
type: boolean
schedulerName:
type: string
secrets:
Expand Down Expand Up @@ -1395,9 +1394,6 @@ spec:
type: string
type: object
type: array
fsGroup:
format: int64
type: integer
hostAliases:
items:
properties:
Expand Down Expand Up @@ -1467,6 +1463,8 @@ spec:
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
type: object
runAsNonRoot:
type: boolean
schedulerName:
type: string
secrets:
Expand Down Expand Up @@ -1986,9 +1984,6 @@ spec:
- name
type: object
type: array
fsGroup:
format: int64
type: integer
hostAliases:
items:
properties:
Expand Down Expand Up @@ -2058,6 +2053,8 @@ spec:
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
type: object
runAsNonRoot:
type: boolean
schedulerName:
type: string
secrets:
Expand Down Expand Up @@ -2695,9 +2692,6 @@ spec:
resolveKey:
type: string
type: object
fsGroup:
format: int64
type: integer
hostAliases:
items:
properties:
Expand Down Expand Up @@ -3592,9 +3586,6 @@ spec:
resolveKey:
type: string
type: object
fsGroup:
format: int64
type: integer
hostAliases:
items:
properties:
Expand Down Expand Up @@ -4141,9 +4132,6 @@ spec:
- name
type: object
type: array
fsGroup:
format: int64
type: integer
hostAliases:
items:
properties:
Expand Down
40 changes: 20 additions & 20 deletions doc/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,15 +1374,15 @@ string
</tr>
<tr>
<td>
<code>fsGroup</code><br/>
<code>runAsNonRoot</code><br/>
<em>
int64
bool
</em>
</td>
<td>
<p>A special supplemental group that applies to all containers in a pod.
Some volume types allow the Kubelet to change the ownership of that volume
to be owned by the pod:</p>
<p>RunAsNonRoot is used to determine whether to run starrocks as a normal user.
If RunAsNonRoot is true, operator will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -2037,15 +2037,15 @@ string
</tr>
<tr>
<td>
<code>fsGroup</code><br/>
<code>runAsNonRoot</code><br/>
<em>
int64
bool
</em>
</td>
<td>
<p>A special supplemental group that applies to all containers in a pod.
Some volume types allow the Kubelet to change the ownership of that volume
to be owned by the pod:</p>
<p>RunAsNonRoot is used to determine whether to run starrocks as a normal user.
If RunAsNonRoot is true, operator will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -2486,15 +2486,15 @@ string
</tr>
<tr>
<td>
<code>fsGroup</code><br/>
<code>runAsNonRoot</code><br/>
<em>
int64
bool
</em>
</td>
<td>
<p>A special supplemental group that applies to all containers in a pod.
Some volume types allow the Kubelet to change the ownership of that volume
to be owned by the pod:</p>
<p>RunAsNonRoot is used to determine whether to run starrocks as a normal user.
If RunAsNonRoot is true, operator will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -2884,15 +2884,15 @@ string
</tr>
<tr>
<td>
<code>fsGroup</code><br/>
<code>runAsNonRoot</code><br/>
<em>
int64
bool
</em>
</td>
<td>
<p>A special supplemental group that applies to all containers in a pod.
Some volume types allow the Kubelet to change the ownership of that volume
to be owned by the pod:</p>
<p>RunAsNonRoot is used to determine whether to run starrocks as a normal user.
If RunAsNonRoot is true, operator will set RunAsUser and RunAsGroup to 1000 in securityContext.
default: nil</p>
</td>
</tr>
<tr>
Expand Down
Loading
Loading