[Doc] update examples/starrocks/deploy_a_starrocks_cluster_with_all_f… #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandongxiao
force-pushed
the
doc/update-doc-deploy_a_starrocks_cluster_with_all_features.yaml
branch
from
c73681d
to
d2142a8
Compare
…eatures.yaml Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
doc/update-doc-deploy_a_starrocks_cluster_with_all_features.yaml
branch
from
d2142a8
to
09b9c66
Compare
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
doc/update-doc-deploy_a_starrocks_cluster_with_all_features.yaml
branch
from
e702f26
to
f60f5af
Compare
kevincai
reviewed
Oct 11, 2023
| # Default failureThreshold is 60 and the periodSeconds is 5, this means the startup | ||
| # will fail if the pod can't start in 300 seconds. Your StartupProbeFailureSeconds is | ||
| # the total time of seconds before startupProbe give up and fail the container start. | ||
| # If startupProbeFailureSeconds can't be divided by defaultPeriodSeconds, the failureThreshold |
There was a problem hiding this comment.
replace tab with spaces?
| @@ -67,10 +67,6 @@ type StarRocksLoadSpec struct { | |||
| // +optional | |||
| Tolerations []corev1.Toleration `json:"tolerations,omitempty"` | |||
|
|
|||
| // Probe defines the mode probe service in container is alive. | |||
There was a problem hiding this comment.
is this forgot to remove in last startuptime period PR?
…s.yaml Signed-off-by: yandongxiao <[email protected]>
kevincai
approved these changes
Oct 13, 2023
yandongxiao
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eatures.yaml