[Feature] allow to config the terminationGracePeriodSeconds #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yandongxiao
commented
Oct 12, 2023
yandongxiao
commented
- [Doc] update examples/starrocks/deploy_a_starrocks_cluster_with_all_features.yaml
- upgrade Go to 1.19
- update examples/starrocks/deploy_a_starrocks_cluster_with_all_features.yaml
- allow to config the terminationGracePeriodSeconds
yandongxiao
force-pushed
the
feature/allow-config-the-terminationGracePeriodSeconds
branch
from
0e8b306
to
157dbd7
Compare
yandongxiao
force-pushed
the
feature/allow-config-the-terminationGracePeriodSeconds
branch
from
157dbd7
to
1add3ba
Compare
kevincai
reviewed
Oct 16, 2023
| @@ -177,6 +177,8 @@ starrocksFESpec: | |||
| # - name: my-configmap | |||
| # mountPath: /etc/my-configmap | |||
| # subPath: "" | |||
| # terminationGracePeriodSeconds defines duration in seconds the FE pod needs to terminate gracefully. | |||
There was a problem hiding this comment.
why there is only 3 occurrence of the terminationGracePeriodSeconds while there are 4 changes in the starrocks_cluster.yaml?
There was a problem hiding this comment.
The terminationGracePeriodSeconds was placed in an incorrect location, allowing the FE Proxy to also set the terminationGracePeriodSeconds.
yandongxiao
force-pushed
the
feature/allow-config-the-terminationGracePeriodSeconds
branch
from
1add3ba
to
a42ffad
Compare
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
feature/allow-config-the-terminationGracePeriodSeconds
branch
from
a42ffad
to
0f6c086
Compare
kevincai
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.