[Enhancement] Support to mount emptyDir in storageVolumes #324
Conversation
yandongxiao
force-pushed
the
feature/support-emptyDir-volume
branch
4 times, most recently
from
3f74778
to
6fb5cce
Compare
yandongxiao
force-pushed
the
feature/support-emptyDir-volume
branch
from
09e0894
to
6fb5cce
Compare
yandongxiao
force-pushed
the
feature/support-emptyDir-volume
branch
4 times, most recently
from
b8434ce
to
f9ba369
Compare
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
feature/support-emptyDir-volume
branch
from
f9ba369
to
4928526
Compare
| @@ -595,3 +613,8 @@ starrocksFeProxySpec: | |||
| # ReadinessProbeFailureSeconds defines the total failure seconds of readiness Probe. | |||
| # default value is 15 seconds | |||
| readinessProbeFailureSeconds: | |||
| # Note: will create emptyDir volume for fe proxy, PVC is not supported. | |||
| emptyDirs: [] | |||
There was a problem hiding this comment.
what if the emptyDirs has a path that conflicts with the storageSpec path?
There was a problem hiding this comment.
Maybe Statefulset will refuse to apply the change to pod? I am not sure, will try it.
There was a problem hiding this comment.
that's what I am afraid of. statefulset refuses the change but the error will be silent to the user, the user is waiting for something happen but never happens, check if we can validate this kind of errors in operator?
There was a problem hiding this comment.
OK, a good suggestion, will check it. And we can also show errors(or k8s event) from statefulset and pod on StarRocksCluster CR. So we can describe the StarRocksCluster CR to get the error.
There was a problem hiding this comment.
right! When the mount path conflicts from multiple configurations, what we can do for now is to refuse the crd apply, or show errors in cr status at least.
There was a problem hiding this comment.
Operator can not refuse the crd apply, we should use k8s webhook to achive this.
fixes #320