Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support tolerations for init-password job #463

Conversation

yandongxiao
Copy link
Collaborator

@yandongxiao yandongxiao commented Mar 11, 2024

Description

when .Values.starrocksFESpec.tolerations or .Values.starrocksCluster.componentValues.tolerations is configured, the FE init-password Job will respect this.

This is the rendered result:

kind: Job
metadata:
  name: starrocks-initpwd
  namespace: starrocks
spec:
  template:
    spec:
      tolerations:
        - effect: NoSchedule
          key: key
          operator: Equal|Exists
          value: value

Checklist

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@yandongxiao yandongxiao force-pushed the enhancement/support-tolerations-for-init-passwd-job branch from 0f84eb4 to f35d953 Compare March 12, 2024 07:28
@yandongxiao yandongxiao merged commit bbd2297 into StarRocks:main Mar 12, 2024
5 checks passed
@yandongxiao yandongxiao added v1.9.4 enhancement New feature or request labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.9.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants