[Enhancement] Check volume name and mount path when default volume is added

[yandongxiao]

Current Issues

In versions prior to v1.9.0, the following configuration could be successfully deployed.

When a user's FE configuration is as follows:

   storageVolumes:
      - mountPath: /opt/starrocks/fe/
        name: fe-meta
        storageClassName: pd-ssd
        storageSize: 200Gi
      - mountPath: /opt/starrocks/fe/log
        name: fe-log
        storageClassName: pd-ssd
        storageSize: 30Gi
      - mountPath: /tmp
        name: tmp-data
        storageClassName: emptyDir

The Operator checks the mountPath and finds that /opt/starrocks/fe/meta does not exist. Therefore, when creating the Statefulset object, an additional fe-meta configuration was added.

        volumeMounts:
        - mountPath: /opt/starrocks/fe/
          name: fe-meta
        - mountPath: /opt/starrocks/fe/log
          name: fe-log
        - mountPath: /tmp
          name: tmp-data
        - mountPath: /opt/starrocks/fe/meta  
          name: fe-meta         # duplicate mount name
        - mountPath: /etc/starrocks/fe/conf
          name: kube-starrocks-fe-cm

      volumes:
      - name: fe-meta
        persistentVolumeClaim:
          claimName: fe-meta
      - name: fe-log
        persistentVolumeClaim:
          claimName: fe-log
      - emptyDir: {}
        name: tmp-data
      - emptyDir: {}
        name: fe-meta   # duplicate volume
      - configMap:
          defaultMode: 420
          name: kube-starrocks-fe-cm
        name: kube-starrocks-fe-cm

The above statefulset configuration can be deployed.

After version 1.9.1, it will check if there is a conflict in the volume name, and the deployment above will fail.

Solution

The key issue is that the Operator currently only relies on the mountpath to determine whether to add a default volume. It should also consider both the volume name and mount path as criteria for adding a default volume.