[Feature] Support command and args

[yandongxiao]

Description

Fixes: #517

Suggestion

Although users can find workarounds, that increases the complexity of their operations.

We can solve the above problems by supporting the command and args field.

1. Maintained compatibility. If the user does not use this, it will not cause the container to restart.
2. We have added examples in values.yaml to make it easy to use command and args.
3. In these examples, after adding the entrypoint in values.yaml, the program structure remains unchanged.

# the original processes
root@kube-starrocks-fe-0:/opt/starrocks# ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 11:01 ?        00:00:00 /bin/bash /opt/starrocks/fe_entrypoint.sh kube-starrocks-fe-service.starrocks
root          16       1 60 11:01 ?        00:00:12 /lib/jvm/default-java/bin/java -Dlog4j2.formatMsgNoLookups=true -Xmx8192m -XX:+UseG1GC -Xlog:gc*:/opt/starrocks/fe/log/fe.gc.log.20240423-110154:time com.starrocks.StarRocksFE -host_type FQDN
root         234       0  0 11:02 pts/0    00:00:00 bash
root         248     234  0 11:02 pts/0    00:00:00 ps -ef

root@kube-starrocks-be-0:/opt/starrocks# ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 11:02 ?        00:00:00 /bin/bash /opt/starrocks/be_entrypoint.sh kube-starrocks-fe-service
root          48       1  2 11:02 ?        00:00:01 /opt/starrocks/be/lib/starrocks_be
root         543       0  1 11:02 pts/0    00:00:00 bash
root         555     543  0 11:03 pts/0    00:00:00 ps -ef

root@kube-starrocks-cn-0:/opt/starrocks# ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 11:02 ?        00:00:00 /bin/bash /opt/starrocks/cn_entrypoint.sh kube-starrocks-fe-service
root          30       1  2 11:02 ?        00:00:01 /opt/starrocks/cn/lib/starrocks_be --cn
root         578       0  0 11:03 pts/0    00:00:00 bash
root         591     578  0 11:03 pts/0    00:00:00 ps -ef


# after entrypoint is specified in values.yaml

root@kube-starrocks-fe-0:/opt/starrocks# ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 10:56 ?        00:00:00 /bin/bash /opt/starrocks/fe_entrypoint.sh kube-starrocks-fe-service.starrocks
root          16       1 30 10:56 ?        00:00:14 /lib/jvm/default-java/bin/java -Dlog4j2.formatMsgNoLookups=true -Xmx8192m -XX:+UseG1GC -Xlog:gc*:/opt/starrocks/fe/log/fe.gc.log.20240423-105617:time com.starrocks.StarRocksFE -host_type FQDN
root         251       0  1 10:57 pts/0    00:00:00 bash
root         263     251  0 10:57 pts/0    00:00:00 ps -ef

root@kube-starrocks-be-0:/opt/starrocks# ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 10:56 ?        00:00:00 /bin/bash /opt/starrocks/be_entrypoint.sh kube-starrocks-fe-service
root          48       1  2 10:56 ?        00:00:01 /opt/starrocks/be/lib/starrocks_be
root         543       0  0 10:57 pts/0    00:00:00 bash
root         556     543  0 10:57 pts/0    00:00:00 ps -ef

root@kube-starrocks-cn-0:/opt/starrocks# ps -ef
UID          PID    PPID  C STIME TTY          TIME CMD
root           1       0  0 10:56 ?        00:00:00 /bin/bash /opt/starrocks/cn_entrypoint.sh kube-starrocks-fe-service
root          30       1  2 10:56 ?        00:00:01 /opt/starrocks/cn/lib/starrocks_be --cn
root         578       0  0 10:57 pts/0    00:00:00 bash
root         590     578  0 10:57 pts/0    00:00:00 ps -ef

Checklist

For operator, please complete the following checklist:

• run make generate to generate the code.
• run golangci-lint run to check the code style.
• run make test to run UT.
• run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

• make sure you have updated the values.yaml
  file of starrocks chart.
• In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
  chart( kube-starrocks chart).

[kevincai]

is this comment still valid?

[yandongxiao]

Yes, I have verified it.

[kevincai]

fix the pr title

[kevincai]

will this mountPath critical to end user, or this can be completely transparent to the end user.

[yandongxiao]

For users, it is indeed unnecessary to specify. We can hide it.

[kevincai]

let's remove it for now.

[yandongxiao]

done