Update values.yaml #530
Merged
Update values.yaml #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that a volume name prefix is required for persistent storage. When I set the name the PVCs were created. Maybe I am wrong, maybe if a storageClassName is set and the prefix is left empty then PVCs will also get created? Signed-off-by: DanRoscigno <[email protected]>
|
Since the kube-starrocks chart is composed of two sub-charts (the operator chart and the starrocks chart), the values.yaml file for the kube-starrocks chart is automatically derived by merging their respective values.yaml files. Therefore, the modification should be made to the values.yaml of the starrocks chart. Then, in the scripts directory, run the bash script create-parent-chart-values.sh to update the values.yaml file of the parent chart (the kube-starrocks chart). |
Signed-off-by: DanRoscigno <[email protected]>
Signed-off-by: DanRoscigno <[email protected]>
|
Thanks @yandongxiao updated and ran the script. |
yandongxiao
approved these changes
May 16, 2024
| @@ -335,7 +335,7 @@ starrocks: | |||
| # Note: Once set, the following fields will not be allowed to be modified. | |||
| storageSpec: | |||
| # Specifies the name prefix of the volumes to mount. If left unspecified, `emptyDir` volumes will be used by default, which | |||
| # are ephemeral and data will be lost on pod restart. For persistent storage, it is recommended to specify a volume name prefix. | |||
| # are ephemeral and data will be lost on pod restart. For persistent storage, specify a volume name prefix. | |||
There was a problem hiding this comment.
Yes you are right, name is required. The values.yaml of starrocks chart also needs to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that a volume name prefix is required for persistent storage. When I set the name the PVCs were created.
Maybe I am wrong, maybe if a storageClassName is set and the prefix is left empty then PVCs will also get created?
Description
Please provide a detailed description of the changes you have made. Include the motivation for these changes, and any
additional context that may be important.
Related Issue(s)
Please list any related issues and link them here.
Checklist
For operator, please complete the following checklist:
make generateto generate the code.golangci-lint runto check the code style.make testto run UT.make manifeststo update the yaml files of CRD.For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).