Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support multiple data volumes on helm chart #578

Conversation

yandongxiao
Copy link
Collaborator

@yandongxiao yandongxiao commented Aug 15, 2024

Description

Support multiple data volumes on helm chart

This show how to configure multiple volumes for BE/CN.

spec:
  starrocksCnSpec:
    storageSpec:
      logStorageSize: 1Gi
      name: cn-storage
      storageSize: 100Gi
      storageCount: 3    # we want to mount 3 volumes and each volume size is 100Gi
    config: |
      sys_log_level = INFO
      # ports for admin, web, heartbeat service
      thrift_port = 9060
      webserver_port = 8040
      heartbeat_service_port = 9050
      brpc_port = 8060
      storage_root_path = /opt/starrocks/cn/storage0;/opt/starrocks/cn/storage1;/opt/starrocks/cn/storage2   # mount them
      
spec:
  starrocksBeSpec:
    storageSpec:
      logStorageSize: 1Gi
      name: be-storage
      storageSize: 100Gi
      storageCount: 2   # we want to mount 2 volumes and each volume size is 100Gi
    config: |
      be_port = 9060
      webserver_port = 8040
      heartbeat_service_port = 9050
      brpc_port = 8060
      sys_log_level = INFO
      default_rowset_type = beta
      storage_root_path = /opt/starrocks/be/storage0;/opt/starrocks/be/storage1    # mount them.

The result shows that It has worked.

root@kube-starrocks-be-0:/opt/starrocks/be# ls
bin  conf  lib  log  spill  storage  storage0  storage1  www
root@kube-starrocks-be-0:/opt/starrocks/be# ls storage
root@kube-starrocks-be-0:/opt/starrocks/be# ls storage0/
cluster_id  data  error_log  meta  persistent  tmp
root@kube-starrocks-be-0:/opt/starrocks/be# ls storage1/
cluster_id  data  meta  persistent  tmp

root@kube-starrocks-cn-0:/opt/starrocks/cn# ls
bin  conf  lib  log  spill  storage  storage0  storage1  storage2  www
root@kube-starrocks-cn-0:/opt/starrocks/cn# ls storage
root@kube-starrocks-cn-0:/opt/starrocks/cn# ls storage0
cluster_id  data  error_log  meta  persistent  tmp
root@kube-starrocks-cn-0:/opt/starrocks/cn# ls storage1
cluster_id  data  meta  persistent  tmp
root@kube-starrocks-cn-0:/opt/starrocks/cn# ls storage2
cluster_id  data  meta  persistent  tmp

Checklist

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@yandongxiao yandongxiao force-pushed the enhancement/support-multiple-volumes-on-helm-chart branch from e487afb to 483e51b Compare August 16, 2024 03:34
@yandongxiao yandongxiao marked this pull request as ready for review August 16, 2024 03:45
storageSize: 1Ti
# If storageMountPath is empty, the storageMountPath will be set to /opt/starrocks/cn/storage.
# the number of persistent volumes for data.
# if its value is greater than 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to revise the comments together with the storageMountPath

  • storageCount == 1, what the storageMountPath means and what the storage_root_path should be configured
  • storageCount > 1, what the storageMountPath means and what the storage_root_path should be configured.

@yandongxiao yandongxiao merged commit 15a7580 into StarRocks:main Aug 21, 2024
5 checks passed
@yandongxiao yandongxiao added v1.9.8 enhancement New feature or request labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.9.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants