Skip to content

Commit

Permalink
[BugFix] Don't update datacache metrics after cache select (backport #…
Browse files Browse the repository at this point in the history
…51764) (#51810)

Co-authored-by: Smith Cruise <[email protected]>
  • Loading branch information
mergify[bot] and Smith-Cruise authored Oct 12, 2024
1 parent 0c0c00b commit 67950d4
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ public static DataCacheSelectMetrics cacheSelect(DataCacheSelectStatement statem
connectContext.setSessionVariable(sessionVariableBackup);

Preconditions.checkNotNull(metrics, "Failed to retrieve cache select metrics");
// Don't update datacache metrics after cache select, because of datacache instance still not unified.
// Here update will display wrong metrics in show backends/compute nodes
// update backend's datacache metrics after cache select
updateBackendDataCacheMetrics(metrics);
// updateBackendDataCacheMetrics(metrics);
return metrics;
}

Expand Down

0 comments on commit 67950d4

Please sign in to comment.