Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix analyzer exception for generated column rewrite (backport #51755) #51806

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 11, 2024

Why I'm doing:

This problem is introduce by pr ##50398. When we re-analyze the generated expression in current scope for subquery, sometime we may meet an exception. In current implementation, a map will be clear but the iteration does not break cause ConcurrentModificationException.

What I'm doing:

Remove the expression if re-analyze throw an exception instead of clear all generated column expression.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51755 done by [Mergify](https://mergify.com). ## Why I'm doing: This problem is introduce by pr ##50398. When we re-analyze the generated expression in current scope for subquery, sometime we may meet an exception. In current implementation, a map will be clear but the iteration does not break cause ConcurrentModificationException.

What I'm doing:

Remove the expression if re-analyze throw an exception instead of clear all generated column expression.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Oct 11, 2024

@wanpengfei-git wanpengfei-git merged commit 2065f81 into branch-3.2 Oct 12, 2024
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-51755 branch October 12, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants