Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make some system tables query from leader fe (backport #51763) #51823

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 12, 2024

Why I'm doing:

some metadata may be inaccurate in the follower fe, because they may be not persisted in leader fe,
such as routine load job state changed from NEED_SCHEDULE to RUNNING.

What I'm doing:

these system tables should query from leader fe.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51763 done by [Mergify](https://mergify.com). ## Why I'm doing: some metadata may be inaccurate in the follower fe, because they may be not persisted in leader fe, such as routine load job state changed from NEED_SCHEDULE to RUNNING.

What I'm doing:

these system tables should query from leader fe.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: wyb <[email protected]>
(cherry picked from commit da80492)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/SystemTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeDataCacheMetricsTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TaskRunsSystemTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TasksSystemTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TemporaryTablesTable.java
#	fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
@mergify mergify bot added the conflicts label Oct 12, 2024
Copy link
Contributor Author

mergify bot commented Oct 12, 2024

Cherry-pick of da80492 has failed:

On branch mergify/bp/branch-3.2/pr-51763
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit da80492936.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeBvarsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeCloudNativeCompactionsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeCompactionsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeConfigsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeLogsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeMetricsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeTabletsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeThreadsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeTxnsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/CharacterSetsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/CollationsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/ColumnPrivilegesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/ColumnsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/EnginesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/EventsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/FeMetricsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/FeTabletSchedulesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/GlobalVariablesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/KeyColumnUsageSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/LoadTrackingLogsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/LoadsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/MaterializedViewsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/PartitionsMetaSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/PartitionsSystemTableSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/PipeFileSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/PipesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/ReferentialConstraintsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/RoutineLoadJobsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/RoutinesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/SchemaPrivilegesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/SchemataSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/SessionVariablesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/StatisticsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/StreamLoadsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TableConstraintsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TablePrivilegesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TablesConfigSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TablesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TriggersSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/UserPrivilegesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/VerboseSessionVariablesSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/ViewsSystemTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/sys/GrantsTo.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/sys/RoleEdges.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/sys/SysFeLocks.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/sys/SysFeMemoryUsage.java
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/sys/SysObjectDependencies.java
	modified:   test/sql/test_routine_load/R/test_commit_offset
	modified:   test/sql/test_routine_load/T/test_commit_offset

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/SystemTable.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeDataCacheMetricsTable.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TaskRunsSystemTable.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TasksSystemTable.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TemporaryTablesTable.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 12, 2024 02:43
@mergify mergify bot closed this Oct 12, 2024
auto-merge was automatically disabled October 12, 2024 02:43

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 12, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@wyb wyb reopened this Oct 12, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 12, 2024 02:57
Copy link

sonarcloud bot commented Oct 12, 2024

@wanpengfei-git wanpengfei-git merged commit a1a525c into branch-3.2 Oct 12, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-51763 branch October 12, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants