Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCORE-83: Fixing accessibility errors in the HTML file #323

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

DemeSzabolcs
Copy link
Contributor

This is a fix for the accessibility errors in the index.html file. Below you can see the accessibility errors:

Asserting the accessibility analysis result failed. Check the accessibility report failure dump for details.
-------- Shouldly.ShouldAssertException : axeResult.Violations
    should be empty but had
1
    item and was
[Selenium.Axe.AxeResultItem (66331987)]

Additional Info:
Links must have discernible text: 
    <a class="btn btn-dark btn-social mx-2" href="<https://www.twitter.com/@">>
                        <i class="fab fa-twitter"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.facebook.com/@">>
                        <i class="fab fa-facebook"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.linkedin.com/in/@">>
                        <i class="fab fa-linkedin"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.twitter.com/@">>
                        <i class="fab fa-twitter"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.facebook.com/@">>
                        <i class="fab fa-facebook"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.linkedin.com/in/@">>
                        <i class="fab fa-linkedin"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.twitter.com/@">>
                        <i class="fab fa-twitter"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.facebook.com/@">>
                        <i class="fab fa-facebook"></i>
                    </a>
    <a class="btn btn-dark btn-social mx-2" href="<https://www.linkedin.com/in/@">>
                        <i class="fab fa-linkedin"></i>
                    </a>
    <a href="#">
                    <img class="img-fluid img-brand d-block mx-auto" src="/media/logos/microsoft.svg" alt="">
                </a>
    <a href="#">
                    <img class="img-fluid img-brand d-block mx-auto" src="/media/logos/google.svg" alt="">
                </a>
    <a href="#">
                    <img class="img-fluid img-brand d-block mx-auto" src="/media/logos/facebook.svg" alt="">
                </a>
    <a href="#">
                    <img class="img-fluid img-brand d-block mx-auto" src="/media/logos/ibm.svg" alt="">
                </a>
    <a class="btn btn-dark btn-social mx-2" href="#!"><i class="fab fa-twitter" aria-hidden="true"></i></a>
    <a class="btn btn-dark btn-social mx-2" href="#!"><i class="fab fa-facebook-f" aria-hidden="true"></i></a>
    <a class="btn btn-dark btn-social mx-2" href="#!"><i class="fab fa-linkedin-in" aria-hidden="true"></i></a>

Also, there are elements with insufficient color contrasts, but I didn't include those errors since I didn't fix them. For those see: #322

@davidtmiller
Copy link
Member

Just getting around to some updates here, thanks for this contribution!

@davidtmiller davidtmiller merged commit 5d6e817 into StartBootstrap:master Mar 22, 2022
davidtmiller added a commit that referenced this pull request Mar 22, 2022
OCORE-83: Fixing accessibility errors in the HTML file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants