-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): Add common component knative #130
Conversation
@sylus Upstream installs Knative serving (v0.17.4) and Knative ingress controller for Istio (v0.17.1) |
We should stay as close to what we have in Kubeflow v2 and along with all of our customizations, but obviously being on the v1.3 line. So this is going to need a bit of work. |
There aren't any customizations from what we have in v2. v2 pointed to https://github.com/kubeflow/manifests/blob/v1.2-branch/knative/installs/generic/kustomization.yaml |
Okay perfect then in v3 id stick as close to what kubeflow says we should run just as a baseline. Its alot easier if something goes wrong to look at the kubeflow issue queue if we following what they are doing. But i'll take a closer look at this one tomorrow :) |
Please note I also made note in the AAW stack that we use the Istio Operator which does alot of the gateway handling for us so I didn't need to bring in that component which is mentioned in kubeflow/manifest as |
Not sure if there is a cleaner way to use one patch to target multiple (in this case) deployment files. |
bb14c8d
to
eed98fb
Compare
Signed-off-by: rohank07 [email protected]