Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Add common component knative #130

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Conversation

rohank07
Copy link
Contributor

Signed-off-by: rohank07 [email protected]

@rohank07 rohank07 linked an issue Jan 19, 2022 that may be closed by this pull request
@rohank07
Copy link
Contributor Author

rohank07 commented Jan 19, 2022

@sylus Upstream installs Knative serving (v0.17.4) and Knative ingress controller for Istio (v0.17.1)
Back in June 2021 David Spek helped setup some of the groundwork for KF v1.3 apps on Kubeflow. For Knative he used Knative serving (v0.22.0) and Knative ingress controller for Istio (v0.22.0). What are your thoughts on which version we install? In David's version he also installs eventing-core and commented it is optional (this was not done in v1,2). This PR installs v0.22.0.

@sylus
Copy link
Member

sylus commented Jan 19, 2022

We should stay as close to what we have in Kubeflow v2 and along with all of our customizations, but obviously being on the v1.3 line. So this is going to need a bit of work.

@rohank07
Copy link
Contributor Author

There aren't any customizations from what we have in v2. v2 pointed to https://github.com/kubeflow/manifests/blob/v1.2-branch/knative/installs/generic/kustomization.yaml

@sylus
Copy link
Member

sylus commented Jan 19, 2022

Okay perfect then in v3 id stick as close to what kubeflow says we should run just as a baseline.

Its alot easier if something goes wrong to look at the kubeflow issue queue if we following what they are doing.

But i'll take a closer look at this one tomorrow :)

@sylus
Copy link
Member

sylus commented Jan 19, 2022

Please note I also made note in the AAW stack that we use the Istio Operator which does alot of the gateway handling for us so I didn't need to bring in that component which is mentioned in kubeflow/manifest as common/istio-1-9/cluster-local-gateway/base

@rohank07
Copy link
Contributor Author

Not sure if there is a cleaner way to use one patch to target multiple (in this case) deployment files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common Component: kubeflow-knative
2 participants