Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade notebook-controller (1.3.1 --> 1.4.1) #215

Conversation

bryanpaget
Copy link
Contributor

@bryanpaget bryanpaget commented Aug 25, 2022

This is part of the Kubeflow 1.4 Upgrade Epic (StatCan/aaw#1203) and resolves the following upgrade issue: #216.

@rohank07 rohank07 linked an issue Aug 31, 2022 that may be closed by this pull request
Copy link
Member

@sylus sylus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the delta via

task stack:aaw:preview

And doesn't even seem to resolve into any delta so looks good

@sylus sylus changed the base branch from kf-1.4-upgrade to aaw-dev-cc-00 September 5, 2022 20:16
@sylus
Copy link
Member

sylus commented Sep 5, 2022

I changed the base since some other P.R.'s wanted to merge into aaw-dev-cc-00, as Argo isn't on auto sync and we will want to keep each indiividual commit history hope this makes sense!

@rohank07 rohank07 merged commit 2594a9f into StatCan:aaw-dev-cc-00 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade 1.4.1 Common Component: notebook-controller
3 participants