Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade 1.6: JWA #1242

Closed
14 tasks
wg102 opened this issue Jul 12, 2022 · 5 comments
Closed
14 tasks

Upgrade 1.6: JWA #1242

wg102 opened this issue Jul 12, 2022 · 5 comments
Assignees
@wg102
Labels
component/jupyter Kubeflow notebooks and associated container images kind/epic An epic

Comments

@wg102
Copy link
Contributor

wg102 commented Jul 12, 2022 •
edited
Loading

This issue is a child of #1203

And Will be done in parallel with the Kubeflow-centraldashboard upgrade.

Steps

  1. Figure how to do the rebasing
  2. Investigate the difficulty of the tasks, both for frontend and backend + create tickets
  3. Fix backend Upgrade 1.6: Fix Backend jupyter-apis#125
  4. Fix frontend

We need to consider merging our front end with the kubeflow repo, to get all the changes in one go. It will be harder to do, but once done, should be easy enough to maintain. This would allow us to have a more structured approach in future upgrades.

Original Title Date Description Pull request # Note Issue TODO
feat(initial): Initial commit 20/08/10 StatCan/jupyter-apis@641a4d6 NA Directly on main
feat(initial): Initial commit 20/08/10 StatCan/jupyter-apis@7f366f8 NA Directly on main - go files
feat(notebooks): Add initial support for creating and delete notebooks 20/08/10 StatCan/jupyter-apis@d36aff0 NA Directly on main - go files
chore(notebooks): Code linting 20/08/10 StatCan/jupyter-apis@4baa196 NA Directly on main - go
fix(http): Set Content-Type on response 20/08/11 StatCan/jupyter-apis@d72939d NA Directly on main - go
feat(notebooks): Add volume and GPU support on Notebook creation 20/08/11 StatCan/jupyter-apis@0f3a9ba NA Directly on main - go
feat(listers): Switch to informers + listers to reduce the number of calls … 20/08/11 StatCan/jupyter-apis@a8363a5 NA Directly on main - go
feat(config): Add config 20/08/11 StatCan/jupyter-apis@e3bcdf7 NA Directly on main - go
feat(frontend): Add jupyter frontend 20/08/11 StatCan/jupyter-apis@16bd974 NA Directly on main - frontend should be there
chore(license): Add frontend license 20/08/11 StatCan/jupyter-apis@f09fe91 NA Directly on main - license
feat(notebooks): Display CPU limits as a decimal 20/08/12 StatCan/jupyter-apis@2f4546a NA Directly on main - go
feat(configurations): Add configurations to the notebooks 20/08/12 StatCan/jupyter-apis@42c7019 NA Directly on main - go
feat(namespaces): Add namespaces response 20/08/13 StatCan/jupyter-apis@4370e46 NA Directly on main - go
feat(response): Update error responses to HTTP 200 because the web in… 20/08/13 StatCan/jupyter-apis@73fafd8 NA Directly on main - go + Dockerfile
fix(notebooks): Return index.html when the new page is requested 20/08/14 StatCan/jupyter-apis@c6280e4 NA Directly on main - go
feat(ci): Automate build and publish 20/08/16 StatCan/jupyter-apis@22f2749 NA Directly on main NA - ci - should be there
feat(ci): Temporarily set back container 20/08/16 StatCan/jupyter-apis@2c07e8d NA Directly on main NA - ci - should be there
feat(ci): Automate build and publish 20/08/16 StatCan/jupyter-apis@3c844b4 NA Directly on main NA - ci - should be there
fix(npm): fix vulnerabilities (squashed commit) 20/08/19 StatCan/jupyter-apis@d32875d +5
Merge pull request 5 from StatCan/try-npm-fix 20/08/19 StatCan/jupyter-apis@c4e6fa7 5 npm fix should not be needed
fix: Update from deprecated font-awesome usage 20/08/19 StatCan/jupyter-apis@b7ee560 +6
feat: Improve local dev setup 20/08/19 StatCan/jupyter-apis@f3eb3cd +6
refactor: Remove unneeded statements, unreachable code 20/08/19 StatCan/jupyter-apis@7d98d21 +6
Merge pull request #6 from StatCan/2-facilitate-local-development 20/08/20 StatCan/jupyter-apis@7ad65c2 6 X
chore: Unset executable flag on front-end files 20/08/21 StatCan/jupyter-apis@3bdcc83 +13
fix: angular mat-form-fiel error 20/08/21 StatCan/jupyter-apis@20ff2f9 +9
Merge pull request #9 from StatCan/fix-angular-component 20/08/21 StatCan/jupyter-apis@f0b855d 9 Fix for bug X
fix: kubeflow collision 20/08/21 StatCan/jupyter-apis@f068e8d +12
Merge pull request #12 from StatCan/fix-kubeflow-collision-information 20/08/21 StatCan/jupyter-apis@5caa0a4 12 css fix X
Merge pull request #13 from StatCan/3-fix-front-end-file-permissions 20/08/21 StatCan/jupyter-apis@978c814 13 They all say 'empty change' ?? merging the flag changes
docs: Update README for local development 20/08/25 StatCan/jupyter-apis@90a1e14 + 14
docs: Update README 20/08/25 StatCan/jupyter-apis@223b9ec + 14
Merge pull request #14 from StatCan/update-read-me 20/08/25 StatCan/jupyter-apis@831d42c 14 Readme NA - Just keep ours
fix: limit local dev deployment 20/08/26 StatCan/jupyter-apis@47455b0 + 15
Merge pull request #15 from StatCan/11-limit-local-dev-deployment 20/08/26 StatCan/jupyter-apis@692c8f4 15 go files NA
chore(fonts): add fonts as assets 20/08/26 StatCan/jupyter-apis@2a1317b + 17
chore(fonts): add fonts to service 20/09/01 StatCan/jupyter-apis@e9c0fdb + 17
Merge pull request #17 from StatCan/fonts-as-assets 20/09/01 StatCan/jupyter-apis@76dcb7b 17 Add asset fonts - is upstream NA is upstream
fix(Dockerfile): add env variable 20/09/14 StatCan/jupyter-apis@282b887 + 21
Merge pull request #21 from StatCan/add-env-variable 20/09/14 StatCan/jupyter-apis@0d174a0 21 Dockerfile NA - Keep ours
fix: notebook server validation 20/09/15 StatCan/jupyter-apis@1e66633 + 19
fix: Fix cross-validation issues, error messages 20/09/05 StatCan/jupyter-apis@32eb310 + 19?
fix: Gi for RAM not optional 20/09/16 StatCan/jupyter-apis@9cbb66c + 19
Merge pull request #19 from StatCan/notebook-server-validation 20/09/16 StatCan/jupyter-apis@22bdc13 19 Name validation, CPu error, component error, default values X - VERY
fix: delete old notebooks (pvc) 20/09/17 StatCan/jupyter-apis@2095188 + 20
fix: resolve dependabot alerts 20/09/23 StatCan/jupyter-apis@faf5415 +23
feat: Add icons to main tables + refactor 20/09/23 StatCan/jupyter-apis@fdb507f +20
fix: browser console ExpressionChanged error 20/09/24 StatCan/jupyter-apis@d2a9537 +23
Merge pull request #23 from StatCan/fix-dependabot-alerts 20/09/24 StatCan/jupyter-apis@1a50add 23 Maybe for the after content check X
fix: Add status to pvc table + refactor 20/10/02 StatCan/jupyter-apis@49fc2b3 + 20
feat: Convey more info via volume status column 20/10/06 StatCan/jupyter-apis@4fabd14 +20
Merge pull request #20 from StatCan/18-destroy-old-notebooks 20/10/06 StatCan/jupyter-apis@2e9daf6 20 VOLUME TABLE X - do 29 at same time
feat: add cost estimate table 20/10/06 StatCan/jupyter-apis@b08cb88 + 27
fix: Improve spacing for new data volume config 20/10/07 StatCan/jupyter-apis@8df1dc8 + 29
Merge pull request #29 from StatCan/28-data-volume-ui-is-squashed 20/10/07 StatCan/jupyter-apis@738e6fd 29 fix CSS VoLUME X - do 20 at same time
Add message when shoose image 20/10/13 StatCan/jupyter-apis@a9e122a + 30
use Prettier 20/10/13 StatCan/jupyter-apis@52cc62b + 30
Merge pull request #30 from StatCan/Change-the-hint-image-message 20/10/14 StatCan/jupyter-apis@9d02488 30 Change a message SHouldnt need should be with i18n X (merge with i18n)
fix: connect to Kubecost API + cleanup and refactor components 20/10/21 StatCan/jupyter-apis@2284c4d + 27
Merge pull request #27 from StatCan/kubecost-estimates 20/10/21 StatCan/jupyter-apis@49dea69 27 Kubecost X - do with 34,40
fix: update ram limits 20/11/03 StatCan/jupyter-apis@f8c29ee +38
Merge pull request #38 from StatCan/fix-max-limits 20/11/03 StatCan/jupyter-apis@344d4fc 38 fix: update ram limits X - find where merge with
feat: Add Official Languages with ngx-translate 20/11/04 StatCan/jupyter-apis@2e213ec + 35
Merge pull request #35 from StatCan/32-angular-ngx-translate 20/11/04 StatCan/jupyter-apis@f938db9 35 II18n - we should NOT need it. but we will need to compare EVERY message NA - should use the upstream i18n
fix: add check for kubecost error response + translation 20/11/06 StatCan/jupyter-apis@460f113 + 34
Merge pull request #34 from StatCan/fix-kubecost-error 20/11/06 StatCan/jupyter-apis@d412a39 34 fix kubecost - do with 27 X - do with 27
fix: kubecost table message 20/11/10 StatCan/jupyter-apis@aeddf81 + 40
Merge pull request #40 from StatCan/fix-kubecost-message 20/11/10 StatCan/jupyter-apis@0fba437 40 fix kubecost message - again - 27 X fo with 27
fix: set max cpu/ram values for 1 gpu + translation 20/12/16 StatCan/jupyter-apis@6c5fa37 + 45
Merge pull request #45 from StatCan/fix-gpu-specs 20/12/16 StatCan/jupyter-apis@0e116fd 45 Validation GPU X maybe with 57
feat: Add validation for mounted pvc 21/01/04 StatCan/jupyter-apis@f2614b6 +51
fix: show error when element is untouched 21/01/04 StatCan/jupyter-apis@22805a3 + 51
Merge pull request #51 from StatCan/50-add-validation-mounted-pvc 21/01/07 StatCan/jupyter-apis@8641aab 51 Validation Mounted volume X
fix: add check for runnning notebook server 21/01/07 StatCan/jupyter-apis@b8a3683 +53
Merge pull request #53 from StatCan/fix-upstream-error 21/01/13 StatCan/jupyter-apis@424b2f9 53 fix-upstream-error X - find where merge with
feat: Add env variable to set language of the notebook server 21/01/21 StatCan/jupyter-apis@83af673 +48
Merge pull request #48 from StatCan/feat-env-var 21/01/21 StatCan/jupyter-apis@2c1532b 48 Add env var for notebook X
fix npm vulnerabilities 21/01/25 StatCan/jupyter-apis@197905b +54
Merge pull request #54 from StatCan/52-fix-npm-vulnerabilities 21/01/26 StatCan/jupyter-apis@d0b5f20 54 fix vulnerabilities - shouldn't be needed NA
fix: lower gpu node cpu-request to allow scheduling 21/02/12 StatCan/jupyter-apis@33372de +57
Merge pull request #57 from StatCan/lower-gpu-cpu-request 21/02/16 StatCan/jupyter-apis@0b55d4d 57 lower-gpu-cpu-request X - maybe with 45
feat: url link to image info page 21/04/20 StatCan/jupyter-apis@68c6546 + 60
Merge pull request #60 from StatCan/image-selection-hint 21/04/20 StatCan/jupyter-apis@5daefc3 60 Add image text hint X
Update README.md 21/05/12 StatCan/jupyter-apis@32a6c91 NA Directly on main - readme
docs: additional info for miniKF 21/05/19 StatCan/jupyter-apis@37c5e7c NA Directly on main - readme
fix: added custom image url validation 21/05/20 StatCan/jupyter-apis@4e2554f + 61
Merge pull request #61 from StatCan/59-add-custom-image-url-validation 21/05/21 StatCan/jupyter-apis@416bcb1 61 custom-image-url-validation X
fix(prob volumes) 21/09/22 StatCan/jupyter-apis@da808ea 63 prob Volume X with 64, 66
fix(use the better label) 21/09/22 StatCan/jupyter-apis@e0a6302 64 add-prob-volv2 - with 63 X with 63
add prob volume label 21/09/29 StatCan/jupyter-apis@24e2ce1 66 prob-volume-label - with 63 X with 63
feat(initial): Initial baseline 22/02/15 StatCan/jupyter-apis@cd1e003 N/A Directly on main - no need cause won't be modified
feat(frontend): Switch to upstream frontend v1.3.0 22/02/15 StatCan/jupyter-apis@dfa205f N/A Directly on main - should be in as default might need similar changes for docker and such don't think need
feat(endpoint): Add update notebook start / stop endpoint 22/02/16 StatCan/jupyter-apis@dcfba4c N/A Directly on main - go giles
feat: Update for Kubeflow v1.3.0 22/02/17 StatCan/jupyter-apis@863a996 67 Go for 1.3
feat(ci): Fix for node-gyp on npm ci 22/02/17 StatCan/jupyter-apis@cdedc61 N/A Directly on main - dockerfile
feat(ci): Fix pathprefix for static 22/02/17 StatCan/jupyter-apis@e8a39d8 N/A Directly on main - go
fix: Return index.html page at the root 22/02/17 StatCan/jupyter-apis@6bed652 N/A Directly on main - go
fix: Strip /static prefix from static resources when sent to the filesystem 22/02/17 StatCan/jupyter-apis@acd0d75 N/A Directly on main - go
feat(doc): Update README.md and SpawnerConfig 22/03/06 StatCan/jupyter-apis@0d3f2bc N/A Directly on main - readme + sample
feat(i18n): Add i18n functionality on top of KF 1.3 22/03/07 StatCan/jupyter-apis@813f13a N/A i18n for 1.3 -- might be needed? ?
feat(ux): Add custom UX improvements + fix():remove kubecost table 22/03/11 StatCan/jupyter-apis@3f6d99b 115 Remove kubecost - IGNORE IGNORE
update spawner_ui_config 22/03/11 StatCan/jupyter-apis@866a7c8 116 fix-image-icon X
feat: change cpu limit 22/04/11 StatCan/jupyter-apis@bdf857c 119 change cpu limit X - find where merge with
Update Readme 22/04/11 StatCan/jupyter-apis@b837df3 118 REadme
feat(imagePullPolicy): Change to Always 22/05/04 StatCan/jupyter-apis@2113334 120 image pull policy change X
feat(imagePullPolicy): Add and set it 22/06/06 StatCan/jupyter-apis@d105c5a 121 One weird change? X
feat(sas): Add UI for SAS workspaces 22/07/12 StatCan/jupyter-apis@fbbd8f1 + 122 Add sass
StatCan/add-ui-for-sas 22/07/12 StatCan/jupyter-apis@5eef1a0 122 Add sass X
feat: bring back kubecost table 22/08/18 StatCan/jupyter-apis@9835ca1 124 Add Kubecost again NA - never removed on branch
TODO LIST:

List of the features:
@wg102 wg102 added the component/jupyter Kubeflow notebooks and associated container images label Jul 12, 2022
@wg102 wg102 mentioned this issue Jul 12, 2022
Closed
7 tasks
@wg102
Copy link
Contributor Author

wg102 commented Jul 12, 2022

We might want to pay a closer attention to this commit: StatCan/jupyter-apis@863a996
It's the upgrade for 1.3.

@wg102
Copy link
Contributor Author

wg102 commented Jul 13, 2022

We will also need to figure out what to do with the Golang Backend, and update the Build scripts accordingly

@bryanpaget bryanpaget mentioned this issue Jul 15, 2022
Closed
@wg102
Copy link
Contributor Author

wg102 commented Aug 10, 2022 •
edited
Loading

Need to decide if we merge it back into the kubeflow repo, or not. And write down the reason for/against. And the final decision. This will have a big impact. This decision will be tracked in the following ticket: #1302

@wg102 wg102 mentioned this issue Aug 10, 2022
Closed
This was referenced Aug 24, 2022
Closed
Closed
@wg102 wg102 mentioned this issue Sep 1, 2022
Closed
7 tasks
@wg102 wg102 added the kind/epic An epic label Sep 9, 2022
@wg102
Copy link
Contributor Author

wg102 commented Sep 9, 2022

Halfway done grouping the PRs together, will finish on Monday, and finish the table up to date (there was kubecost back too)

@wg102 wg102 changed the title Upgrade 1.4: JWA Upgrade 1.6: JWA Sep 12, 2022
This was referenced Sep 12, 2022
Closed
Closed
@wg102
Copy link
Contributor Author

wg102 commented Sep 12, 2022

A new epic was created to handle those commits to redeploy. See StatCan/jupyter-apis#131

@wg102 wg102 closed this as completed Sep 12, 2022
@wg102 wg102 self-assigned this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wg102 wg102

Labels
component/jupyter Kubeflow notebooks and associated container images kind/epic An epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wg102