Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 1.4: Inquire about how to rebase JWA #1325

Closed
wg102 opened this issue Aug 24, 2022 · 5 comments
Closed

Upgrade 1.4: Inquire about how to rebase JWA #1325

wg102 opened this issue Aug 24, 2022 · 5 comments
Assignees
Labels
size/S ~1 day

Comments

@wg102
Copy link
Contributor

wg102 commented Aug 24, 2022

Sub item of epic: #1242
Ask the people who did the rebase previously.
The issue is that it comes from a different repository.

Front end and backend.

@wg102 wg102 added the size/S ~1 day label Aug 24, 2022
@wg102 wg102 self-assigned this Aug 24, 2022
@wg102
Copy link
Contributor Author

wg102 commented Aug 25, 2022

Backend

After a quick chat with Will, it seems the way they have done the update previously is to launch the upstream jupyter-api, then open devtools and take a look at any of the requests that the webapp is making to the backend, along with their payloads and then update the golang schema for any corrections.

Frontend

What to do with the front end?...
The big changes are:
Migrate to Angular 12 from 8:
Merging our i18n
Refactor i18n to use angular's default

Option 1:
Create a new master branch, copy the file directories
Redo all our work on top of it

Option 2:
Manually do the upgrade to angular 12
Manually do any additional changes from their side.

@wg102
Copy link
Contributor Author

wg102 commented Aug 25, 2022

I will be going with option 1. Between the big changes they did it should be fast enough to do our own modifications on top. I will make the list and execute it.

@wg102 wg102 removed the size/M 2-3 days label Aug 26, 2022
@wg102
Copy link
Contributor Author

wg102 commented Sep 1, 2022

This is the physical differences, there are also a lot of validation
image
The volume table
The price table

@wg102
Copy link
Contributor Author

wg102 commented Sep 6, 2022

The investigation is done. There is a ticket on how to deploy angular

@wg102 wg102 closed this as completed Sep 6, 2022
@wg102
Copy link
Contributor Author

wg102 commented Sep 6, 2022

See StatCan/jupyter-apis#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S ~1 day
Projects
None yet
Development

No branches or pull requests

1 participant