Feature 1.6 passes tests #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yannis Zarkadas <[email protected]>
Removing myself as an owner. This should lead to better auto-assignment of code reviews.
* jwa(front): Add npm rule for checking the format Signed-off-by: Kimonas Sotirchos <[email protected]> * ci: Add common tasks for format checks Signed-off-by: Kimonas Sotirchos <[email protected]> * ci(jwa): Add format check tasks Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(back): Fix formatting Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(front): Fix formatting Run `npm run format:write` on frontend Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(front): Include prettier in package.json Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(docker): Don't copy node_modules in Dockerfile Signed-off-by: Kimonas Sotirchos <[email protected]> * web-apps: Add global dockerignore file Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa: Remove unused dockerignore file Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(make): Don't include dockerignore and cleanup Signed-off-by: Kimonas Sotirchos <[email protected]>
When the TB controller attempts to schedule a RWO PVC it checks its accessModes in the PVC status. The controller panics if the list is empty. This commit adds a check to ensure the list is not empty. Signed-off-by: Ilias Katsakioris <[email protected]>
* api: Add marker for preserving unknown fields in Plugins Signed-off-by: Yannis Zarkadas <[email protected]> * manifests: Regenerate manifests Signed-off-by: Yannis Zarkadas <[email protected]>
…urable (kubeflow#5823) * rebase: Make logos configurable in configmap and remove trademark references Rebased to remove the changes to the package-lock.json * review: add suggested changes and add image group section to README
…low#5815) * Make notebook limits configurable with a multiplication factor * Make limits configurable under advanced section * run prettier to format frontend code * fix formatting and add rounding in backend * Return error if limit is smaller than request * Allow disabling limitFactor by setting it to none * review: remove camelCase in python backend * fix: update spawner_ui_config.yaml in manifests directory * review: fix setting limits backend * review: remove unnecessary check from backend
* vwa(front): Add npm script to check the formatting Signed-off-by: Kimonas Sotirchos <[email protected]> * vwa(front): Update the package-lock.json Run `npm install` to bring the package-lock.json up to date Signed-off-by: Kimonas Sotirchos <[email protected]> * vwa(front): Fix formatting Signed-off-by: Kimonas Sotirchos <[email protected]> * vwa(back): Fix formatting Signed-off-by: Kimonas Sotirchos <[email protected]> * vwa(docker): Remove unused dockerignore file We have created a global dockerignore file for all the web apps in the parent dir. Signed-off-by: Kimonas Sotirchos <[email protected]> * vwa(docker): Don't copy node_modules in dockerfile Signed-off-by: Kimonas Sotirchos <[email protected]> * vwa(make): Don't include dockerignore Signed-off-by: Kimonas Sotirchos <[email protected]> * ci(vwa): Add format check tasks Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(docker): Copy only necessary files for build Signed-off-by: Kimonas Sotirchos <[email protected]> * review: Use docker context instead of cd .. Don't use a `cd ..` and copy dockerignore files back and forth. Instead we should use the Docker context and the global dockerignore file we have for all the web apps. Signed-off-by: Kimonas Sotirchos <[email protected]>
* jwa(front): Add static logos in the app The app does not contain the logos' svgs in its source code/static files. This results in the icons to not show when developing locally. This commit adds the svgs found in the logos ConfigMap to the static files of the app as well. Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(front): Change logos fetch url Change the URLs of the logos from `static/assets/*` to `static/assets/logos`. Signed-off-by: Kimonas Sotirchos <[email protected]> * jwa(manifests): Don't override assets with logos Mount the ConfigMap under the `static/assets/logos` directory to not override the contents of the entire assets dir. Signed-off-by: Kimonas Sotirchos <[email protected]>
* Make it possible to add Namespaced menu items * Reduce the nesting levels
…ubeflow#5891) * Update form.py * Update form.py * Update form-default.component.ts * fix whitespace issue
* cwa(front): Ignore font files in assets * feat(jupyter): add fonts as assets to service * CRUD: fonts in common * CWA: Remove link to css file * jwa(front): Remove font assets from jupyter Co-authored-by: Wendy Gaultier <[email protected]>
* Update base notebook for Renovate compatibility * Separate kubectl and S6 arch
…n iframe (kubeflow#5961) * Update jupyter, rstudio and vs code notebook images * Remove sed and use substring removal
…w#5952) * [fix]: Make jupyter-web-app parse workspace volume MountPath - workspace volume path was fixed with "/home/jovyan" - it should be enable to parse from jupyter-web-app-config's data * change parsing key correctly
Knative control-plane components need to probe certain paths of Knative Pods, in order to function correctly. These paths are: - /healthz - /metrics - /ready - /wait-for-drain For this reason, we extend the Profile Controller to apply an Istio AuthorizationPolicy that allows traffic to these HTTP paths for Pods in user namespaces, as per Knative's instructions: https://knative.dev/docs/serving/istio-authorization/#allowing-access-from-system-pods-by-paths This only fixes requests through the public ingress. Cluster-internal traffic and predictor-transformer use-cases are not supported yet. We continue discussing these in kubeflow#5965. Refs kubeflow#5965 Refs kserve/kserve#1558 Signed-off-by: Yurii Komar <[email protected]>
* feat(jupyter): Support hiding image registry/tag * feat(jupyter): Support hiding VSCode/RStudio images registry/tag * rebasing onto upstream master * fix: formatting with prettier and set default hideRegistry=true * fix: move hideRegistry and hideTag from spawnerFormDefaults.image * fix whitespace * add tooltip for images Co-authored-by: JessicaBarh <[email protected]>
* Update dockerfiles and make compatible with Renovate * Set memory for jupyter pytorch to the same as jupyter tensorflow * Update protobuf * Remove conda version and use substring expansion * Update SQLAlchemy * Update dill
# Conflicts: # .github/workflows/build-centraldashboard.yml # .github/workflows/build-notebookcontroller.yml # OWNERS # ROADMAP.md # components/admission-webhook/go.mod # components/admission-webhook/go.sum # components/admission-webhook/manifests/base/crd.yaml # components/admission-webhook/manifests/base/kustomization.yaml # components/centraldashboard/Dockerfile # components/centraldashboard/package-lock.json # components/centraldashboard/package.json # components/centraldashboard/public/components/main-page.js # components/crud-web-apps/common/frontend/kubeflow-common-lib/package-lock.json # components/crud-web-apps/common/frontend/kubeflow-common-lib/package.json # components/crud-web-apps/common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/positive-number-input/positive-number-input.component.html # components/crud-web-apps/common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/resource-table.module.ts # components/crud-web-apps/common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/table/table.component.ts # components/crud-web-apps/common/frontend/kubeflow-common-lib/projects/kubeflow/src/public-api.ts # components/crud-web-apps/jupyter/Dockerfile # components/crud-web-apps/jupyter/Makefile # components/crud-web-apps/jupyter/README.md # components/crud-web-apps/jupyter/backend/apps/common/form.py # components/crud-web-apps/jupyter/backend/apps/common/yaml/spawner_ui_config.yaml # components/crud-web-apps/jupyter/backend/apps/default/routes/post.py # components/crud-web-apps/jupyter/frontend/.gitignore # components/crud-web-apps/jupyter/frontend/angular.json # components/crud-web-apps/jupyter/frontend/e2e/tsconfig.json # components/crud-web-apps/jupyter/frontend/i18n/fr/messages.fr.xlf # components/crud-web-apps/jupyter/frontend/i18n/messages.xlf # components/crud-web-apps/jupyter/frontend/package-lock.json # components/crud-web-apps/jupyter/frontend/package.json # components/crud-web-apps/jupyter/frontend/src/app/app.component.spec.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-advanced-options/form-advanced-options.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-affinity-tolerations/form-affinity-tolerations.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-configurations/form-configurations.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-cpu-ram/form-cpu-ram.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-cpu-ram/form-cpu-ram.component.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-data-volumes/form-data-volumes.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-default.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-default.component.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-gpus/form-gpus.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-gpus/form-gpus.component.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-image/form-image.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-name/form-name.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-workspace-volume/form-workspace-volume.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-workspace-volume/form-workspace-volume.component.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/utils.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/volume/volume.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/volume/volume.component.spec.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-rok/form-rok.component.html # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-rok/rok-form-data-volumes/rok-form-data-volumes.component.spec.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-rok/rok-form-data-volumes/rok-form-data-volumes.component.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-rok/rok-form-workspace-volume/rok-form-workspace-volume.component.spec.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-rok/rok-volume/rok-volume.component.spec.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-rok/utils.ts # components/crud-web-apps/jupyter/frontend/src/app/pages/index/index-default/config.ts # components/crud-web-apps/jupyter/frontend/src/app/types.ts # components/crud-web-apps/jupyter/frontend/src/proxy.conf.json # components/crud-web-apps/jupyter/manifests/base/configs/spawner_ui_config.yaml # components/crud-web-apps/jupyter/manifests/base/kustomization.yaml # components/crud-web-apps/tensorboards/frontend/package-lock.json # components/crud-web-apps/tensorboards/frontend/package.json # components/crud-web-apps/tensorboards/frontend/src/app/pages/index/config.ts # components/crud-web-apps/tensorboards/manifests/base/kustomization.yaml # components/crud-web-apps/volumes/Dockerfile # components/crud-web-apps/volumes/Makefile # components/crud-web-apps/volumes/frontend/package-lock.json # components/crud-web-apps/volumes/frontend/package.json # components/crud-web-apps/volumes/frontend/src/app/pages/index/config.ts # components/crud-web-apps/volumes/manifests/base/kustomization.yaml # components/example-notebook-servers/README.md # components/example-notebook-servers/base/Dockerfile # components/example-notebook-servers/codeserver-python/Dockerfile # components/example-notebook-servers/codeserver/Dockerfile # components/example-notebook-servers/jupyter-pytorch-full/cpu.Dockerfile # components/example-notebook-servers/jupyter-pytorch-full/cuda.Dockerfile # components/example-notebook-servers/jupyter-pytorch/cpu.Dockerfile # components/example-notebook-servers/jupyter-pytorch/cuda.Dockerfile # components/example-notebook-servers/jupyter-scipy/Dockerfile # components/example-notebook-servers/jupyter-tensorflow-full/cpu.Dockerfile # components/example-notebook-servers/jupyter-tensorflow-full/cuda.Dockerfile # components/example-notebook-servers/jupyter-tensorflow/cpu-requirements.txt # components/example-notebook-servers/jupyter-tensorflow/cpu.Dockerfile # components/example-notebook-servers/jupyter-tensorflow/cuda.Dockerfile # components/example-notebook-servers/jupyter/Dockerfile # components/example-notebook-servers/jupyter/requirements.txt # components/example-notebook-servers/rstudio-tidyverse/Dockerfile # components/example-notebook-servers/rstudio/Dockerfile # components/notebook-controller/config/base/kustomization.yaml # components/notebook-controller/controllers/notebook_controller.go # components/profile-controller/config/base/kustomization.yaml # components/profile-controller/config/base/namespace-labels.yaml # components/profile-controller/config/overlays/kubeflow/kustomization.yaml # components/profile-controller/controllers/profile_controller.go # components/profile-controller/controllers/profile_controller_test.go # components/profile-controller/go.mod # components/profile-controller/go.sum # components/profile-controller/main.go # components/tensorboard-controller/config/base/kustomization.yaml # components/tensorboard-controller/config/crd/bases/tensorboard.kubeflow.org_tensorboards.yaml # components/tensorboard-controller/go.mod # components/tensorboard-controller/go.sum # releasing/update-manifests-images # releasing/version/VERSION
Re-add readiness probe plus comment indicating this is a downstream addition.
8de6feb The above commit has been added.
Some fixes were lost in the rebase. They have been added back.
I've changed CustomObjectApi --> Custom_objectsApi and CoreV1Api --> Core_v1Api in a few places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.